module: fix extensionless CJS files in type:module packages

PR nodejs#61600 made the CJS loader respect the package.json
type field for extensionless files, which fixed nodejs#61104
but also enforced type: "module" for extensionless
files. This broke CJS extensionless files inside ESM
packages (e.g. yargs v17).

Only enforce type: "commonjs" for extensionless files.
For type: "module", leave format undefined so syntax
detection handles it. This restores the documented
exception in the CJS documentation that has existed
since v16: extensionless files in type: "module"
packages are recognized as CJS when included via
require().

Fixes: nodejs#61971
Refs: yargs/yargs#2509
Refs: nodejs#61600
PR-URL: nodejs#62083

Author: mcollina

lib/internal/modules/cjs/loader.js

@@ -1952,12 +1952,12 @@ Module._extensions['.js'] = function(module, filename) {
       format = 'typescript';
     }
   } else if (path.extname(filename) === '') {
-    // Extensionless files skip the .js suffix check above. When type is explicit,
-    // follow it so ESM syntax surfaces as SyntaxError for commonjs instead of
-    // silently delegating to ESM.
+    // Extensionless files skip the .js suffix check above. When type is commonjs, follow it so ESM
+    // syntax surfaces as SyntaxError. For type: module, leave format undefined so our syntax
+    // detection handles it (allowing CJS extensionless files in ESM packages).
     pkg = packageJsonReader.getNearestParentPackageJSON(filename);
     const typeFromPjson = pkg?.data?.type;
-    if (typeFromPjson === 'commonjs' || typeFromPjson === 'module') {
+    if (typeFromPjson === 'commonjs') {
       format = typeFromPjson;
     }
   }

test/es-module/test-extensionless-esm-type-commonjs.js

@@ -17,3 +17,13 @@ spawnSyncAndAssert(process.execPath, [
   stdout: /script STARTED[\s\S]*v\d+\./,
   trim: true,
 });
+
+// CJS extensionless file inside a type: "module" package should work
+// when require()'d. Regression test for https://github.com/nodejs/node/issues/61971
+spawnSyncAndAssert(process.execPath, [
+  '-e', `const m = require(${JSON.stringify(
+    fixtures.path('es-modules', 'extensionless-cjs-module', 'index')
+  )}); if (m.hello !== 'world') throw new Error('expected CJS exports, got: ' + JSON.stringify(m))`,
+], {
+  status: 0,
+});

test/fixtures/es-modules/extensionless-cjs-module/index

@@ -0,0 +1 @@
+module.exports = { hello: 'world' };

test/fixtures/es-modules/extensionless-cjs-module/package.json

@@ -0,0 +1,3 @@
+{
+  "type": "module"
+}