Add tests for efferent coupling at module level.

Author: Barnabás Domozi

plugins/cpp_metrics/test/sources/parser/CMakeLists.txt

@@ -6,4 +6,5 @@ add_library(CppMetricsTestProject STATIC
   typemccabe.cpp
   lackofcohesion.cpp
   bumpyroad.cpp
-  afferentcoupling.cpp)
+  afferentcoupling.cpp
+  modulemetrics.cpp)

plugins/cpp_metrics/test/sources/parser/module_a/a1.h

@@ -0,0 +1,13 @@
+#ifndef CC_CPP_MODULE_METRICS_TEST_A1
+#define CC_CPP_MODULE_METRICS_TEST_A1
+
+#include "./a2.h"
+
+namespace CC_CPP_MODULE_METRICS_TEST
+{
+class A1 {
+  A2 a2;
+};
+}
+
+#endif

plugins/cpp_metrics/test/sources/parser/module_a/a2.h

@@ -0,0 +1,13 @@
+#ifndef CC_CPP_MODULE_METRICS_TEST_A2
+#define CC_CPP_MODULE_METRICS_TEST_A2
+
+#include "../module_b/b1.h"
+
+namespace CC_CPP_MODULE_METRICS_TEST
+{
+class A2 {
+  B1 b1;
+};
+}
+
+#endif

plugins/cpp_metrics/test/sources/parser/module_b/b1.h

@@ -0,0 +1,13 @@
+#ifndef CC_CPP_MODULE_METRICS_TEST_B1
+#define CC_CPP_MODULE_METRICS_TEST_B1
+
+#include "./b2.h"
+
+namespace CC_CPP_MODULE_METRICS_TEST
+{
+class B1 {
+  B2 b2;
+};
+}
+
+#endif

plugins/cpp_metrics/test/sources/parser/module_b/b2.h

@@ -0,0 +1,9 @@
+#ifndef CC_CPP_MODULE_METRICS_TEST_B2
+#define CC_CPP_MODULE_METRICS_TEST_B2
+
+namespace CC_CPP_MODULE_METRICS_TEST
+{
+class B2 {};
+}
+
+#endif

plugins/cpp_metrics/test/sources/parser/module_c/c1.h

@@ -0,0 +1,15 @@
+#ifndef CC_CPP_MODULE_METRICS_TEST_C1
+#define CC_CPP_MODULE_METRICS_TEST_C1
+
+#include "../module_b/b1.h"
+#include "./c2.h"
+
+namespace CC_CPP_MODULE_METRICS_TEST
+{
+class C1 {
+  B1 b1;
+  C2 c2;
+};
+}
+
+#endif

plugins/cpp_metrics/test/sources/parser/module_c/c2.h

@@ -0,0 +1,13 @@
+#ifndef CC_CPP_MODULE_METRICS_TEST_C2
+#define CC_CPP_MODULE_METRICS_TEST_C2
+
+#include "../module_a/a2.h"
+
+namespace CC_CPP_MODULE_METRICS_TEST
+{
+class C2 {
+  A2 a2;
+};
+}
+
+#endif

plugins/cpp_metrics/test/sources/parser/modulemetrics.cpp

@@ -0,0 +1,6 @@
+#include "./module_a/a1.h"
+#include "./module_a/a2.h"
+#include "./module_b/b1.h"
+#include "./module_b/b2.h"
+#include "./module_c/c1.h"
+#include "./module_c/c2.h"

plugins/cpp_metrics/test/src/cppmetricsparsertest.cpp

@@ -13,6 +13,8 @@
 #include <model/cppfunction-odb.hxx>
 #include <model/cppastnodemetrics.h>
 #include <model/cppastnodemetrics-odb.hxx>
+#include <model/cppfilemetrics.h>
+#include <model/cppfilemetrics-odb.hxx>
 
 #include <util/dbutil.h>
 #include <util/odbtransaction.h>
@@ -21,6 +23,8 @@ using namespace cc;
 
 extern char* dbConnectionString;
 
+typedef std::pair<std::string, unsigned int> StringUintParam;
+
 class CppMetricsParserTest : public ::testing::Test
 {
 public:
@@ -62,14 +66,12 @@ bool CppMetricsParserTest::queryRecordMetric(
 
 // McCabe
 
-typedef std::pair<std::string, unsigned int> McCabeParam;
-
 class ParameterizedMcCabeTest
   : public CppMetricsParserTest,
-    public ::testing::WithParamInterface<McCabeParam>
+    public ::testing::WithParamInterface<StringUintParam>
 {};
 
-std::vector<McCabeParam> paramMcCabe = {
+std::vector<StringUintParam> paramMcCabe = {
   {"conditionals", 8},
   {"loops1", 6},
   {"loops2", 6},
@@ -173,10 +175,10 @@ INSTANTIATE_TEST_SUITE_P(
 
 class ParameterizedTypeMcCabeTest
   : public CppMetricsParserTest,
-    public ::testing::WithParamInterface<McCabeParam>
+    public ::testing::WithParamInterface<StringUintParam>
 {};
 
-std::vector<McCabeParam> paramTypeMcCabe = {
+std::vector<StringUintParam> paramTypeMcCabe = {
   {"Empty",                           0},
   {"ClassMethodsInside",             16},
   {"ClassMethodsOutside",            44},
@@ -271,13 +273,12 @@ INSTANTIATE_TEST_SUITE_P(
 
 // Afferent coupling
 
-typedef std::pair<std::string, unsigned int> AfferentParam;
 class ParameterizedAfferentCouplingTest
   : public CppMetricsParserTest,
-    public ::testing::WithParamInterface<AfferentParam>
+    public ::testing::WithParamInterface<StringUintParam>
 {};
 
-std::vector<AfferentParam> paramAfferent = {
+std::vector<StringUintParam> paramAfferent = {
   {"A",   1},
   {"A2",  1},
   {"A3",  1},
@@ -320,3 +321,35 @@ INSTANTIATE_TEST_SUITE_P(
   ParameterizedAfferentCouplingTest,
   ::testing::ValuesIn(paramAfferent)
 );
+
+// Efferent coupling at module level
+
+class ParameterizedEfferentModuleCouplingTest
+  : public CppMetricsParserTest,
+    public ::testing::WithParamInterface<StringUintParam>
+{};
+
+std::vector<StringUintParam> paramEfferentModule = {
+  {"%/test/sources/parser/module_a", 1},
+  {"%/test/sources/parser/module_b", 0},
+  {"%/test/sources/parser/module_c", 2},
+};
+
+TEST_P(ParameterizedEfferentModuleCouplingTest, ModuleEfferentTest) {
+  _transaction([&, this]() {
+
+    typedef odb::query<model::CppModuleMetricsForPathView> CppModuleMetricsQuery;
+
+    const auto metric = _db->query_value<model::CppModuleMetricsForPathView>(
+      CppModuleMetricsQuery::CppFileMetrics::type == model::CppFileMetrics::Type::EFFERENT_MODULE &&
+      CppModuleMetricsQuery::File::path.like(GetParam().first));
+
+    EXPECT_EQ(GetParam().second, metric.value);
+  });
+}
+
+INSTANTIATE_TEST_SUITE_P(
+  ParameterizedEfferentModuleCouplingTestSuite,
+  ParameterizedEfferentModuleCouplingTest,
+  ::testing::ValuesIn(paramEfferentModule)
+);