Fix bug where setting svdAddrGapThreshold to 0 in launch.json caused … (#38)

mikeschmidt-glydways · web-flow · commit b9889d43f671 · 2025-07-19T03:29:45.000-04:00
* Fix bug where setting svdAddrGapThreshold to 0 in launch.json caused the default gap of 16 to be used instead. Check "thresh == undefined" instead of "!thresh".

* Use strict equality in thresh comparison
diff --git a/src/views/peripheral.ts b/src/views/peripheral.ts
@@ -388,7 +388,7 @@ export class PeripheralTreeProvider implements vscode.TreeDataProvider<Periphera
         this.sessionPeripheralsMap.set(session.id, regs);
         let thresh = session.configuration[manifest.CONFIG_ADDRGAP];
 
-        if (!thresh) {
+        if (thresh === undefined) {
             thresh = vscode.workspace.getConfiguration(manifest.PACKAGE_NAME).get<number>(manifest.CONFIG_ADDRGAP) || manifest.DEFAULT_ADDRGAP;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -388,7 +388,7 @@ export class PeripheralTreeProvider implements vscode.TreeDataProvider<Periphera`
`388`	`388`	`this.sessionPeripheralsMap.set(session.id, regs);`
`389`	`389`	`let thresh = session.configuration[manifest.CONFIG_ADDRGAP];`
`390`	`390`
`391`		`- if (!thresh) {`
	`391`	`+ if (thresh === undefined) {`
`392`	`392`	`thresh = vscode.workspace.getConfiguration(manifest.PACKAGE_NAME).get<number>(manifest.CONFIG_ADDRGAP) \|\| manifest.DEFAULT_ADDRGAP;`
`393`	`393`	`}`
`394`	`394`