Skip to content

boot: zephyr: Add PSOC Edge case in flash_map_extended.c#2673

Closed
lauracarlesso wants to merge 1 commit into
mcu-tools:mainfrom
lauracarlesso:carl-ifx-add-psoc-edge-case
Closed

boot: zephyr: Add PSOC Edge case in flash_map_extended.c#2673
lauracarlesso wants to merge 1 commit into
mcu-tools:mainfrom
lauracarlesso:carl-ifx-add-psoc-edge-case

Conversation

@lauracarlesso
Copy link
Copy Markdown

Add the correct selection for FLASH_DEVICE for the Infineon PSOC Edge family of devices.

Add the correct selection for FLASH_DEVICE for the Infineon
PSOC Edge family of devices.

Signed-off-by: Laura Carlesso <laura.carlesso@infineon.com>
Copy link
Copy Markdown
Collaborator

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why you are duplicating what already exists in lines 54 to 57

@lauracarlesso
Copy link
Copy Markdown
Author

I have no idea why you are duplicating what already exists in lines 54 to 57

That section uses

#define FLASH_DEVICE_BASE CONFIG_FLASH_BASE_ADDRESS

whereas I need

#define FLASH_DEVICE_BASE 0

for the purposes of the mcuboot I need FLASH DEVICE BASE to have value 0 but I still want to maintain CONFIG_FLASH_BASE_ADDRESS with its proper value throughout the rest of the implementation where it's used.

@nordicjm
Copy link
Copy Markdown
Collaborator

I have no idea why you are duplicating what already exists in lines 54 to 57

That section uses

#define FLASH_DEVICE_BASE CONFIG_FLASH_BASE_ADDRESS

whereas I need

#define FLASH_DEVICE_BASE 0

for the purposes of the mcuboot I need FLASH DEVICE BASE to have value 0 but I still want to maintain CONFIG_FLASH_BASE_ADDRESS with its proper value throughout the rest of the implementation where it's used.

that is not valid, so I'm not really sure what you're asking for or what you are doing, but it is wrong. If you are not using the zephyr,mapped-partition binding then maybe you should update to that and retry

@de-nordic de-nordic added the area: zephyr Affects the Zephyr port label Mar 26, 2026
@lauracarlesso
Copy link
Copy Markdown
Author

Redesigned the implementation and this is no longer needed (nor would it have been valid) so closing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: zephyr Affects the Zephyr port

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants