✨ Add PHP lint pattern support

Added support for PHP lint error messages to the PATTERNS list in logToCs.py.

Author: mdeweerd

README.md

@@ -153,6 +153,9 @@ In the script, patterns can be added to "PATTERNS" to match more messages.
 
 To allow multiline patterns, the python module 'regex' is required.
 
+To debug, `python3 -m trace --ignore-dir=/usr/lib -t LogToCs.py` can be
+used where you would just call the script to get a line by line trace.
+
 ## Author(s):
 
 - [mdeweerd]

logToCs.py

@@ -419,6 +419,12 @@ def submit(  # pylint: disable=too-many-arguments
         f"^{FILE_REGEX}{EOL_REGEX}"
         rf"\s+{LINE_REGEX}:{COLUMN_REGEX}\s+{SEVERITY_REGEX}\s+{MSG_REGEX}$"
     ),
+    # php lint: php -l
+    # PHP Parse error:  syntax error, ... in path/to/file on line 531
+    re.compile(
+        rf"^PHP Parse error:\s+{MSG_REGEX} in {FILE_REGEX}"
+        f" on line {LINE_REGEX}$"
+    ),
     # hurl:
     #  error: Error message
     #     --> api/contracts/10_contracts.hurl:3:6
@@ -609,7 +615,9 @@ def parse_message(message):
     Returns the fields in a dict.
     """
     for pattern in PATTERNS:
+        # print(pattern.pattern)  # Help for debug
         fields = pattern.match(message, re.IGNORECASE)
+        # print(f"{fields!r} - {message}")  # Help for debug
         if not fields:
             continue
         result = fields.groupdict()
@@ -644,7 +652,7 @@ def parse_message(message):
     return None
 
 
-def add_error_entry(  # pylint: disable=too-many-arguments,unused-argument
+def add_error_entry(  # pylint: disable=too-many-arguments,unused-argument,too-many-positional-arguments  # noqa: E501
     root,
     severity,
     file_name,

tests/IN/phan2.log

@@ -0,0 +1,3 @@
+htdocs\public\members\new.php:1027 PhanTypeMismatchArgumentProbablyReal Argument 10 ($disabled) is '' of type '' but \Form::selectarray() takes int (no real type) defined at htdocs\core\class\html.form.class.php:9556 (the inferred real argument type has nothing in common with the parameter's phpdoc type)
+htdocs\public\members\new.php:1027 PhanTypeMismatchArgumentProbablyReal Argument 6 ($value_as_key) is '' of type '' but \Form::selectarray() takes int (no real type) defined at htdocs\core\class\html.form.class.php:9556 (the inferred real argument type has nothing in common with the parameter's phpdoc type)
+htdocs\public\members\new.php:1027 PhanTypeMismatchArgument Argument 7 ($moreparam) is 0 of type 0 but \Form::selectarray() takes string defined at htdocs\core\class\html.form.class.php:9556

tests/IN/phan2.txt

@@ -0,0 +1,3 @@
+::error file=htdocs/public/members/new.php,line=1027::PhanTypeMismatchArgumentProbablyReal Argument 10 ($disabled) is '' of type '' but \Form::selectarray() takes int (no real type) defined at htdocs\core\class\html.form.class.php:9556 (the inferred real argument type has nothing in common with the parameter's phpdoc type)
+::error file=htdocs/public/members/new.php,line=1027::PhanTypeMismatchArgumentProbablyReal Argument 6 ($value_as_key) is '' of type '' but \Form::selectarray() takes int (no real type) defined at htdocs\core\class\html.form.class.php:9556 (the inferred real argument type has nothing in common with the parameter's phpdoc type)
+::error file=htdocs/public/members/new.php,line=1027::PhanTypeMismatchArgument Argument 7 ($moreparam) is 0 of type 0 but \Form::selectarray() takes string defined at htdocs\core\class\html.form.class.php:9556

tests/IN/phan2.xml

@@ -0,0 +1,2 @@
+<?xml version='1.0' encoding='utf_8'?>
+<checkstyle version="6.5"><file name="htdocs\public\members\new.php"><error severity="error" line="1027" message="PhanTypeMismatchArgumentProbablyReal Argument 10 ($disabled) is '' of type '' but \Form::selectarray() takes int (no real type) defined at htdocs\core\class\html.form.class.php:9556 (the inferred real argument type has nothing in common with the parameter's phpdoc type)" /><error severity="error" line="1027" message="PhanTypeMismatchArgumentProbablyReal Argument 6 ($value_as_key) is '' of type '' but \Form::selectarray() takes int (no real type) defined at htdocs\core\class\html.form.class.php:9556 (the inferred real argument type has nothing in common with the parameter's phpdoc type)" /><error severity="error" line="1027" message="PhanTypeMismatchArgument Argument 7 ($moreparam) is 0 of type 0 but \Form::selectarray() takes string defined at htdocs\core\class\html.form.class.php:9556" /></file></checkstyle>

tests/IN/phplint.log

@@ -0,0 +1 @@
+PHP Parse error:  syntax error, unexpected token "." in htdocs/modulebuilder/template/core/modules/modMyModule.class.php on line 531

tests/IN/phplint.txt

@@ -0,0 +1 @@
+::error file=htdocs/modulebuilder/template/core/modules/modMyModule.class.php,line=531::syntax error, unexpected token "."

tests/IN/phplint.xml

@@ -0,0 +1,2 @@
+<?xml version='1.0' encoding='utf_8'?>
+<checkstyle version="6.5"><file name="htdocs/modulebuilder/template/core/modules/modMyModule.class.php"><error severity="error" line="531" message="syntax error, unexpected token &quot;.&quot;" /></file></checkstyle>