Reduce react-devtools-custom overhead by deferring hook inspection#1
Merged
Conversation
…ge collection Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…o ChangeDescription Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Index hook lookup entries by fiber memoizedState index so zero-slot hooks like useContext do not shift hook change resolution. Also clarify detected/resolved hook change types and add a regression test for useContext before useState.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
inspectHooksOfFiberis too expensive for this use case. On frequently updating components, it can become slow enough to freeze the browser.Approach
Revert hook change detection to the pre-facebook#35123 behavior. Then defer parsing hook metadata, such as hook names, until after the commit completes, and add caching so hook inspection runs at most once per fiber whenever possible.
Limitations
For now, special handling is only implemented for:
SyncExternalStoreTransitionActionStateFormStateTesting
yarn test --project devtools --build packages/react-devtools-custom/src/__tests__/profilingCache-test.js --runInBand