Conversation
Replace `ts-node` with `tsx` for running `cli.ts` via the `generate` script. `tsx` is actively maintained and starts faster; it handles the extensionless `./index` import and the `./package.json` JSON import without extra configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace
ts-nodewithtsxin theapipackage for runningcli.tsvia thegeneratescript.Motivation
Make it easier to maintain the dev toolchain:
tsxis actively maintained and starts faster thants-node, which is effectively in maintenance mode.Additional details
api/package.json:generatescript now runstsx cli.ts;ts-node ^10.9.1devDependency replaced withtsx ^4.23.1.tsxhandles the extensionless./indeximport and the./package.jsonJSON import without extra configuration, so no source changes were needed.npm test(runsnpm run generate && rm -r out), which completes without errors.Related issues and pull requests