FF152 MediaCapabilities.decodingInfo/encodingInfo() - config.type.webrtc option#29739
Conversation
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
3eb8c5e to
ea86bfa
Compare
|
To understand this PR, is the following the desired nesting? MediaCapabilities:
|
Is this the rule? I think you have more recent experience with nested data structures. Would like to hear your thoughts. |
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
ea86bfa to
a7b62fd
Compare
…alues Use fetch API convention: configuration_parameter as parent, sub-properties as plain names with "property" descriptions nested inside it, and _option suffix for enum values of the type property.
a7b62fd to
805c65c
Compare
|
Thanks @Elchi3.
I used to do the schema defined way, but have been told recently (and asked to modify my PRs) to support a nested form. I recalled "option" being used for enumerated values but I can't find evidence of that. We this needs to be discussed in the BCD meeting to confirm the schema and naming convention to use and then I can match it. My preference is nested "FWIW" - it just feels cleaner and more logical - provided the rendering in MDN works adequately. If that happens ideally I can just drop the last commit. |
Thanks Hamish, this is exactly spot on. We also agreed that nesting is better and that we even have better validation/linting in place if features are properly nested. The guidelines are old and need to be rewritten. They were in fact written because MDN couldn't render deeply nested structures but we believe this is no longer the case. If you could drop the last commit and go back to nested, that would be great! Daniel also noted that there is prior art in this Fetch PR for a good structure: #29451 We should be using names from the specification but roughly, it should be like this.
Expect an issue (and a PR) on the BCD guidelines soon. Sorry for the back and forth. |
805c65c to
7d24f9e
Compare
|
Thanks @Elchi3 I've reverted the last commit so this should be good to review. From the guideline PR #29856 it is not clear if the property needs a prefix in its key name (assume not) or if options values need a prefix. See #29856 (comment) |
Elchi3
left a comment
There was a problem hiding this comment.
Thanks Hamish! I think this can be merged now.
FF152 adds support for the
configuration.type.webrtcoption to be passed toMediaCapabilities.decodingInfo()andMediaCapabilities.encodingInfo(), and removes the non-standard "alias"transmissionthat has been around since FF63ish. The addition is behind the flagmedia.mediacapabilities.webrtc.enabled. Bug is https://bugzilla.mozilla.org/show_bug.cgi?id=1825286To do this I have created a structure of nested features to mirror the
configurationoption, which hastypeproperty, and below that has the newwebrtcandtransmission(to be removed when this is merged). Also moved an existing key below that configuraiton option.Related docs work can be tracked in mdn/content#44174