Update codec preference handling for video#44581
Merged
Merged
Conversation
Code calling preferCodec in changeVideoCodec has missing parameters
github-actions
Bot
added
Content:Media
Co-authored-by: Hamish Willee <hamishwillee@gmail.com>
github-actions
Bot
added
size/s
Contributor
|
Preview URLs (1 page) |
hamishwillee
approved these changes
Jun 29, 2026
hamishwillee
left a comment
hamishwillee
left a comment
Collaborator
There was a problem hiding this comment.
Thanks very much @celalergun - and congratulations on landing your first MDN PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code calling preferCodec in changeVideoCodec has missing parameters
There is a sample code in the documentation that calls preferCodec method with one parameter but the real method expects two parameters.
Description
I added the required parameter
Motivation
I was executing the code in my head but it did not feel right. I checked the rest of the documentation and noticed the mistake.
Additional details
None
Related issues and pull requests
None