fix(search): scroll only results#1548
Open
TGianella wants to merge 1 commit into
Open
Conversation
Contributor
|
8f6e22a was deployed to: https://fred-pr1548.review.mdn.allizom.net/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change the results row size from
min-contentto1frin the search modal.Motivation
min-contentwas causing the grid track to be as high as the wholeulcontaining the search results, so theulitself couldn't be a scroll container because its content wasn't overflowing its height. Hence the next parent (dialog) with a capped width became the scroll container and the whole dialog scrolled (with the input field).1frfixes that by having the grid track never be higher than the available height up to the max-height ofdialogso content can overflow theuland it becomes a scroll container. 🎉I also don't think the track height behaves differently when the search results are not long enough to overflow. Because the
dialoghas no intrinsic height the results row fits the height of the content so there isn't empty space at the bottom of the dialog.Additional details
Related issues and pull requests
Closes #1474