Skip to content

fix(search): scroll only results #1548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TGianella wants to merge 2 commits into
base: main
Choose a base branch
from
+41 −38
Open

fix(search): scroll only results #1548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f33ec7a
fix(search): scroll only results
TGianella May 7, 2026
068fda5
refactor: migrate search dialog from grid to flexbox
TGianella May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions components/search-modal/element.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,28 +42,31 @@ dialog {
}

&[open] {
display: grid;

grid-template-areas:
"search close"
"progress progress"
"results results";
grid-template-rows: var(--navigation-height) min-content min-content;
grid-template-columns: 1fr min-content;
display: flex;
flex-direction: column;
}
}

progress {
grid-area: progress;
flex-shrink: 0;
margin: 0 1rem 0.5rem;

@media (--screen-menu-hamburger) {
margin-inline: 0.3rem;
}
}

.header {
display: flex;

flex-shrink: 0;

align-items: center;

height: var(--navigation-height);
}

.close {
grid-area: close;
font-size: 1.37rem;

@media (--screen-menu-full) {
Expand All @@ -74,7 +77,8 @@ progress {
form {
display: grid;

grid-area: search;
flex: 1;

grid-template-columns: min-content 1fr;

gap: 0.5rem;
Expand Down Expand Up @@ -125,11 +129,8 @@ input {
}

ul {
grid-area: results;

padding: 0;
margin: 0;

overflow: auto;

&:has(li) {
Expand Down
50 changes: 26 additions & 24 deletions components/search-modal/element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,30 +252,32 @@ export class MDNSearchModal extends L10nMixin(LitElement) {
@toggle=${this._toggle}
closedby="any"
>
<form
method="get"
action=${`/${this.locale}/search`}
@submit=${this._submit}
>
<input
type="search"
name="q"
.value=${this._query}
autocomplete="off"
autofocus
@input=${this._input}
placeholder=${this.l10n("search-modal-search")`Search`}
aria-label=${this.l10n("search-modal-search")`Search`}
/>
</form>
<mdn-button
class="close"
variant="plain"
icon-only
.icon=${exitIcon}
@click=${this._close}
>${this.l10n("search-modal-exit-search")`Exit search`}</mdn-button
>
<div class="header">
<form
method="get"
action=${`/${this.locale}/search`}
@submit=${this._submit}
>
<input
type="search"
name="q"
.value=${this._query}
autocomplete="off"
autofocus
@input=${this._input}
placeholder=${this.l10n("search-modal-search")`Search`}
aria-label=${this.l10n("search-modal-search")`Search`}
/>
</form>
<mdn-button
class="close"
variant="plain"
icon-only
.icon=${exitIcon}
@click=${this._close}
>${this.l10n("search-modal-exit-search")`Exit search`}</mdn-button
>
</div>
${this._queryIndex.render({
initial: this._renderLoadingSearchIndex.bind(this),
pending: this._renderLoadingSearchIndex.bind(this),
Expand Down
Loading