Skip to content

Commit 103c449

Browse files
mdvaccafacebook-github-bot
authored andcommitted
Fix NonStaticNestedClass: Make inner class static (facebook#55501)
Summary: The BaseVMFocusChangeListener inner class does not reference any members of its outer class BaseViewManager. Making it static improves memory efficiency by avoiding the implicit reference to the outer class instance. Also removed the unused type parameter <V extends View> and changed the method parameters from T to View since only View interface methods are used. changelog: [internal] internal Reviewed By: cortinico Differential Revision: D92020879
1 parent 6802eb9 commit 103c449

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/BaseViewManager.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1012,18 +1012,18 @@ public void setTouchCancel(@NonNull T view, boolean value) {
10121012
* especially helpful for views that are recycled so we can retain and restore the original
10131013
* listener upon recycling (onDropViewInstance).
10141014
*/
1015-
private class BaseVMFocusChangeListener<V extends View> implements OnFocusChangeListener {
1015+
private static class BaseVMFocusChangeListener implements OnFocusChangeListener {
10161016
private @Nullable OnFocusChangeListener mOriginalFocusChangeListener;
10171017

10181018
public BaseVMFocusChangeListener(@Nullable OnFocusChangeListener originalFocusChangeListener) {
10191019
mOriginalFocusChangeListener = originalFocusChangeListener;
10201020
}
10211021

1022-
public void attach(T view) {
1022+
public void attach(View view) {
10231023
view.setOnFocusChangeListener(this);
10241024
}
10251025

1026-
public void detach(T view) {
1026+
public void detach(View view) {
10271027
view.setOnFocusChangeListener(mOriginalFocusChangeListener);
10281028
}
10291029

0 commit comments

Comments
 (0)