Skip to content

Commit 9937a5d

Browse files
mdvaccafacebook-github-bot
authored andcommitted
Fix MissingOverrideAnnotation: Add @OverRide to flex methods (facebook#55502)
Summary: This change adds missing Override annotations to three methods in LayoutShadowNode that override methods from the parent class: - setFlex(float) - setFlexGrow(float) - setFlexShrink(float) These methods call super.setFlex/setFlexGrow/setFlexShrink, indicating they override parent methods and should have Override annotations for code clarity and compiler checking. changelog: [internal] internal Reviewed By: alanleedev Differential Revision: D92021000
1 parent 5fac8ac commit 9937a5d

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/LayoutShadowNode.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,7 @@ public void setMaxHeight(Dynamic maxHeight) {
230230
maxHeight.recycle();
231231
}
232232

233+
@Override
233234
@ReactProp(name = ViewProps.FLEX, defaultFloat = 0f)
234235
public void setFlex(float flex) {
235236
if (isVirtual()) {
@@ -238,6 +239,7 @@ public void setFlex(float flex) {
238239
super.setFlex(flex);
239240
}
240241

242+
@Override
241243
@ReactProp(name = ViewProps.FLEX_GROW, defaultFloat = 0f)
242244
public void setFlexGrow(float flexGrow) {
243245
if (isVirtual()) {
@@ -309,6 +311,7 @@ public void setGap(Dynamic gap) {
309311
gap.recycle();
310312
}
311313

314+
@Override
312315
@ReactProp(name = ViewProps.FLEX_SHRINK, defaultFloat = 0f)
313316
public void setFlexShrink(float flexShrink) {
314317
if (isVirtual()) {

0 commit comments

Comments
 (0)