Fix HasBetterKotlinAlternativeMethod: Use Kotlin joinToString in TextAttributeProps (facebook#55505)

mdvacca · facebook-github-bot · commit c2feb339f817 · 2026-02-12T09:01:08.000-08:00
Summary:

Replace `TextUtils.join(", ", features)` with Kotlin's idiomatic `features.joinToString(", ")` to fix the HasBetterKotlinAlternativeMethod lint warning. Also removed the now-unused `TextUtils` import while keeping the `TextUtils.TruncateAt` import that is still in use.

changelog: [internal] internal

Reviewed By: alanleedev

Differential Revision: D92021465
diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextAttributeProps.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextAttributeProps.kt
@@ -9,7 +9,6 @@ package com.facebook.react.views.text
 
 import android.os.Build
 import android.text.Layout
-import android.text.TextUtils
 import android.text.TextUtils.TruncateAt
 import android.util.LayoutDirection
 import android.view.Gravity
@@ -238,7 +237,7 @@ public class TextAttributeProps private constructor() {
         }
       }
     }
-    fontFeatureSettings = TextUtils.join(", ", features)
+    fontFeatureSettings = features.joinToString(", ")
   }
 
   private fun setFontWeight(fontWeightString: String?) {

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,6 @@ package com.facebook.react.views.text`
`9`	`9`
`10`	`10`	`import android.os.Build`
`11`	`11`	`import android.text.Layout`
`12`		`-import android.text.TextUtils`
`13`	`12`	`import android.text.TextUtils.TruncateAt`
`14`	`13`	`import android.util.LayoutDirection`
`15`	`14`	`import android.view.Gravity`
`@@ -238,7 +237,7 @@ public class TextAttributeProps private constructor() {`
`238`	`237`	`}`
`239`	`238`	`}`
`240`	`239`	`}`
`241`		`- fontFeatureSettings = TextUtils.join(", ", features)`
	`240`	`+ fontFeatureSettings = features.joinToString(", ")`
`242`	`241`	`}`
`243`	`242`
`244`	`243`	`private fun setFontWeight(fontWeightString: String?) {`