Skip to content

Commit d7ed433

Browse files
mdvaccafacebook-github-bot
authored andcommitted
Fix MissingOverrideAnnotation: Add @OverRide to UIManagerModule methods
Summary: Fixed MissingOverrideAnnotation lint errors in UIManagerModule.java. Added Override annotation to sendAccessibilityEvent(), addUIManagerEventListener(), removeUIManagerEventListener(), and updateRootLayoutSpecs() methods which override methods from a superclass but were missing the annotation. changelog: [internal] internal Differential Revision: D95412726
1 parent c522aac commit d7ed433

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -567,6 +567,7 @@ public EventDispatcher getEventDispatcher() {
567567
return null;
568568
}
569569

570+
@Override
570571
@ReactMethod
571572
public void sendAccessibilityEvent(int tag, int eventType) {
572573
int uiManagerType = ViewUtil.getUIManagerType(tag);
@@ -601,10 +602,12 @@ public void addUIBlock(UIBlock block) {}
601602
*/
602603
public void prependUIBlock(UIBlock block) {}
603604

605+
@Override
604606
public void addUIManagerEventListener(UIManagerListener listener) {
605607
mUIManagerListeners.add(listener);
606608
}
607609

610+
@Override
608611
public void removeUIManagerEventListener(UIManagerListener listener) {
609612
mUIManagerListeners.remove(listener);
610613
}
@@ -631,6 +634,7 @@ public void invalidateNodeLayout(int tag) {}
631634
* Updates the styles of the {@link ReactShadowNode} based on the Measure specs received by
632635
* parameters. offsetX and offsetY aren't used in non-Fabric, so they're ignored here.
633636
*/
637+
@Override
634638
public void updateRootLayoutSpecs(
635639
final int rootViewTag,
636640
final int widthMeasureSpec,

0 commit comments

Comments
 (0)