Skip to content

Commit fa779d2

Browse files
mdvaccafacebook-github-bot
authored andcommitted
Delete enableFabricRenderer() from ReactNativeNewArchitectureFeatureFlags (facebook#56860)
Summary: The `enableFabricRenderer()` flag is being removed entirely; it was always set to true in the canary release stage. All callers of `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()` were inlined in earlier diffs. This diff: - Removes the wrapper method `ReactNativeNewArchitectureFeatureFlags.enableFabricRenderer()`. - Removes the `override fun enableFabricRenderer(): Boolean = true` from `ReactNativeNewArchitectureFeatureFlagsDefaults`. Both classes are non-`generated`, so they are edited directly. The next diff will remove the underlying `ReactNativeFeatureFlags.enableFabricRenderer()` API by regenerating the codegen output. Behavior is unchanged. Changelog: [Internal] Reviewed By: javache Differential Revision: D105231777
1 parent b94190f commit fa779d2

2 files changed

Lines changed: 0 additions & 14 deletions

File tree

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeNewArchitectureFeatureFlags.kt

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -35,18 +35,6 @@ public object ReactNativeNewArchitectureFeatureFlags {
3535
return ReactNativeFeatureFlags.enableBridgelessArchitecture()
3636
}
3737

38-
@JvmStatic
39-
public fun enableFabricRenderer(): Boolean {
40-
if (ReactBuildConfig.UNSTABLE_ENABLE_MINIFY_LEGACY_ARCHITECTURE) {
41-
Assertions.assertCondition(
42-
ReactNativeFeatureFlags.enableFabricRenderer(),
43-
"ReactNativeFeatureFlags.enableFabricRenderer() should be set to TRUE when Strict Mode is enabled",
44-
)
45-
return true
46-
}
47-
return ReactNativeFeatureFlags.enableFabricRenderer()
48-
}
49-
5038
@JvmStatic
5139
public fun useFabricInterop(): Boolean {
5240
if (ReactBuildConfig.UNSTABLE_ENABLE_MINIFY_LEGACY_ARCHITECTURE) {

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeNewArchitectureFeatureFlagsDefaults.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ public open class ReactNativeNewArchitectureFeatureFlagsDefaults() :
2525

2626
override fun enableBridgelessArchitecture(): Boolean = true
2727

28-
override fun enableFabricRenderer(): Boolean = true
29-
3028
override fun useNativeViewConfigsInBridgelessMode(): Boolean = true
3129

3230
override fun useTurboModuleInterop(): Boolean = true

0 commit comments

Comments
 (0)