Skip to content

Commit bab293d

Browse files
committed
docs: credit @c266 for the PHP 8.5 __doRequest fix (#180)
1 parent bdea03d commit bab293d

2 files changed

Lines changed: 11 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1818

1919
- **PHP 8.4 / 8.5 fatal error.** `SoapClient::__doRequest()` gained a 6th parameter
2020
(`?string $uriParserClass`); the incompatible override made the class fatal to autoload.
21-
The override now matches the parent signature. ([#179])
21+
The override now matches the parent signature. ([#179], thanks [@c266] for [#180])
2222
- **High CPU load in parallel mode.** `doRequests()` busy-waited on `curl_multi_exec()` and
2323
pegged the CPU at 100% while endpoints responded. It now blocks on `curl_multi_select()`
2424
between rounds. ([#47])
@@ -57,4 +57,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
5757
[#175]: https://github.com/meabed/php-parallel-soap/issues/175
5858
[#47]: https://github.com/meabed/php-parallel-soap/issues/47
5959
[#11]: https://github.com/meabed/php-parallel-soap/issues/11
60+
[#180]: https://github.com/meabed/php-parallel-soap/pull/180
61+
[@c266]: https://github.com/c266
6062
[4.0.0]: https://github.com/meabed/php-parallel-soap/compare/3.0.1...4.0.0

README.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -207,6 +207,14 @@ Contributions are welcome — please review the [guidelines](CONTRIBUTING.md):
207207

208208
See [CHANGELOG.md](CHANGELOG.md) for a list of notable changes.
209209

210+
## Acknowledgements
211+
212+
Thanks to everyone who has reported issues and contributed fixes, including
213+
[@c266](https://github.com/c266) for independently diagnosing the PHP 8.5 `__doRequest()`
214+
signature break ([#180](https://github.com/meabed/php-parallel-soap/pull/180), [#179]).
215+
216+
[#179]: https://github.com/meabed/php-parallel-soap/issues/179
217+
210218
## License
211219

212220
Released under the [MIT license](LICENSE.md).

0 commit comments

Comments
 (0)