WIP: Fix bugs

medengineer · medengineer · commit 36b0bd88abf6 · 2025-05-30T23:01:51.000-07:00
diff --git a/Source/Processors/ProcessorGraph/ProcessorGraph.cpp b/Source/Processors/ProcessorGraph/ProcessorGraph.cpp
@@ -1083,7 +1083,7 @@ void ProcessorGraph::updateUndoableActions (int nodeId)
     for (auto action : getUndoableActions (nodeId))
     {
         GenericProcessor* p = getProcessorWithNodeId (nodeId);
-        p->update();
+        //p->update();
         action->restoreOwner (p);
     }
 }
diff --git a/Source/Processors/RecordNode/RecordNode.cpp b/Source/Processors/RecordNode/RecordNode.cpp
@@ -146,7 +146,8 @@ void RecordNode::parameterValueChanged (Parameter* p)
     {
         int selectedIdx = ((CategoricalParameter*) p)->getSelectedIndex();
         setEngine (getAvailableRecordEngines()[selectedIdx]->getID());
-        createNewDirectory();
+        // NOTE: Any record engine change will create a new directory for all record nodes to prevent data loss in edge cases
+        CoreServices::createNewRecordingDirectory();
     }
     else if (p->getName() == "events")
     {

Original file line number	Diff line number	Diff line change
`@@ -1083,7 +1083,7 @@ void ProcessorGraph::updateUndoableActions (int nodeId)`
`1083`	`1083`	`for (auto action : getUndoableActions (nodeId))`
`1084`	`1084`	`{`
`1085`	`1085`	`GenericProcessor* p = getProcessorWithNodeId (nodeId);`
`1086`		`- p->update();`
	`1086`	`+ //p->update();`
`1087`	`1087`	`action->restoreOwner (p);`
`1088`	`1088`	`}`
`1089`	`1089`	`}`
Original file line number	Diff line number	Diff line change
`@@ -146,7 +146,8 @@ void RecordNode::parameterValueChanged (Parameter* p)`
`146`	`146`	`{`
`147`	`147`	`int selectedIdx = ((CategoricalParameter*) p)->getSelectedIndex();`
`148`	`148`	`setEngine (getAvailableRecordEngines()[selectedIdx]->getID());`
`149`		`- createNewDirectory();`
	`149`	`+ // NOTE: Any record engine change will create a new directory for all record nodes to prevent data loss in edge cases`
	`150`	`+ CoreServices::createNewRecordingDirectory();`
`150`	`151`	`}`
`151`	`152`	`else if (p->getName() == "events")`
`152`	`153`	`{`