Skip to content

updated event listeners to use Marionette 2.4.x event names#1

Open
peterzen wants to merge 6 commits into
medialize:masterfrom
peterzen:master
Open

updated event listeners to use Marionette 2.4.x event names#1
peterzen wants to merge 6 commits into
medialize:masterfrom
peterzen:master

Conversation

@peterzen

Copy link
Copy Markdown

No description provided.

@rodneyrehm

Copy link
Copy Markdown
Member

thx!

do you need me to merge this, or can you work with your branch for the time being? I'm considering letting this PR dangle until I get to rework the module…

a) please don't - ever - bump version numbers in pull requests
b) you're upgrading a Marionette 1 plugin to Marionette 2 - that certainly isn't a bug-fix release, but a major change. see marionette.migrate for more…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants