You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When compiling a sass file using indented syntax, imported files are not compiled using indented syntax and throw syntax errors. I added a failing test to demonstrate that.
There's a long standing issue for the Importer infrastructure to gain the ability to specify the format of the returned content: sass/libsass#1695. That said, in #72 we worked around that problem within sass.js another: sass.node.js. The trick is to write the content to emscripten's file system using Sass.writeFile() and have the Importer Callback return the proper path instead of content. libsass will then use the correct parser (SASS vs SCSS) based on the file's extension.
The lower level "fix" would be to include calling sass2scss() in sass_importer_emscripten(), which would also make it necessary to add a flag (like done) to specify if the imported string should be treated as SASS. However, I'd prefer to wait for libsass to solve this issue properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling a sass file using indented syntax, imported files are not compiled using indented syntax and throw syntax errors. I added a failing test to demonstrate that.