Fix incorrect reference start time for reclaiming session timeout#3643
Open
lminiero wants to merge 1 commit into
Open
Fix incorrect reference start time for reclaiming session timeout#3643lminiero wants to merge 1 commit into
lminiero wants to merge 1 commit into
Conversation
Contributor
|
I will test on 0.16.2 version |
Member
Author
You'll need to port the fix to |
Contributor
|
Works as expected. session_timeout = 90 Last keep-alive: LTE is turned OFF -> connection is closed: Connection is restored: Call is complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address the issue reported on the group, about a broken behaviour of our reclaim session functionality. As per the documentation, if a reclaim session timeout is configured, when a transport goes away you have X seconds to try and restore it from a different transport: the code was using the last activity as a start for the timeout, though, which was incorrect, since the last activity may precede the time we detect a transport to be gone, in some cases preventing any chance to reclaim due to early cleanups. This PR introduces a new timer that we track when the transport actually is detected as gone, and that we use in the related check.
Not tested yet, so please provide feedback on whether this works correctly and/or if it causes regressions.