forked from strands-agents/sdk-python
-
Notifications
You must be signed in to change notification settings - Fork 0
Unify model and session interface #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
1ab25c6
refactor(model): unify bidirectional model and session
261e25f
fix: update bidirectional model docstrings
a9d8c88
fix: remove base session references
17686d4
feat: throw exceptions when connect is called on already active conne…
c2f88f7
feat: Add explicit init params for gemini and openai to free kwargs
55554aa
test: Consolidate bidi model tests
28fe471
fix: update comments
60eb493
fix: move import to top
6529187
fix: use protocol and improve _active handling
990d905
refactor: simplify model names
5f5e425
Merge branch 'main' into provider-interface-refactor
231f171
fix: address comments in pr
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 7 additions & 11 deletions
18
src/strands/experimental/bidirectional_streaming/models/__init__.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,17 +1,13 @@ | ||
| """Bidirectional model interfaces and implementations.""" | ||
|
|
||
| from .bidirectional_model import BidirectionalModel, BidirectionalModelSession | ||
| from .gemini_live import GeminiLiveBidirectionalModel, GeminiLiveSession | ||
| from .novasonic import NovaSonicBidirectionalModel, NovaSonicSession | ||
| from .openai import OpenAIRealtimeBidirectionalModel, OpenAIRealtimeSession | ||
| from .bidirectional_model import BidirectionalModel | ||
| from .gemini_live import GeminiLiveModel | ||
| from .novasonic import NovaSonicModel | ||
| from .openai import OpenAIRealtimeModel | ||
|
|
||
| __all__ = [ | ||
| "BidirectionalModel", | ||
| "BidirectionalModelSession", | ||
| "GeminiLiveBidirectionalModel", | ||
| "GeminiLiveSession", | ||
| "NovaSonicBidirectionalModel", | ||
| "NovaSonicSession", | ||
| "OpenAIRealtimeBidirectionalModel", | ||
| "OpenAIRealtimeSession", | ||
| "GeminiLiveModel", | ||
| "NovaSonicModel", | ||
| "OpenAIRealtimeModel", | ||
| ] |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.