forked from strands-agents/harness-sdk
-
Notifications
You must be signed in to change notification settings - Fork 0
fix: Improve Gemini Live model provider #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
a9784f0
temp commit message, review the changes
5ace082
Merge branch 'bidi-event-types' into bidi-gemini-improvements
f7c18d4
fix: improve gemini test script to display interrupts and remove exce…
bf8c0e9
Merge branch 'main' into bidi-gemini-improvements
c06ec6f
remove text logging
490ce1e
fix(gemini): return multiple tool use events
2dbe7f0
Merge branch 'main' into bidi-gemini-improvements
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think to start it is okay to return the tool uses one at a time (we will execute them concurrently). But if a model supports returning multiple tool uses at once, we should give users the ability to control the execution pattern just as we do for uni agents. It may be that a user wants the tool uses processed sequentially for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that makes sense, but I wanted to start by reusing our tool events. I think later on, we can introduce list of tool events as another event? releasing this right now is not one way door, so i'd be in favor of going forward now, and taking it as a feature request after launch.
So far, I have not seen any model return multiple tool uses, it's always different events