Skip to content

fix: formatting, linting errors#30

Closed
mehtarac wants to merge 12 commits into
mainfrom
fix_github_workflow
Closed

fix: formatting, linting errors#30
mehtarac wants to merge 12 commits into
mainfrom
fix_github_workflow

Conversation

@mehtarac
Copy link
Copy Markdown
Owner

Description

In this PR, the fix includes linting error fixes, formatting error fixes, and typing error fixes based on running the command hatch run prepare

Related Issues

Documentation PR

Type of Change

Bug fix
New feature
Breaking change
Documentation update
Other (please describe):

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

try:
adapter.stop()
logger.debug(f"Cleaned up adapter: {type(adapter).__name__}")
logger.debug("adapter=<%s> | cleaned up adapter", type(adapter).__name__)
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are we using adapter naming?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update this -- I had the change ready but realized i never pushed it my Agent PR. Can fix this in a follow up


@property
def audio(self) -> str:
"""Get the audio data."""
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we provide audio bytes as a property? 🤔


class _ToolCaller:
"""Provides common tool calling functionality that can be used by both traditional
"""Provides common tool calling functionality for Agent and BidirectionalAgent classes.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: BidiAgent

@github-actions github-actions Bot removed the size/xl label Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants