Skip to content

C2C-434: Show list of patients in MSPP Family planning report#80

Merged
kdaud merged 15 commits into
masterfrom
c2c-434
Jan 20, 2026
Merged

C2C-434: Show list of patients in MSPP Family planning report#80
kdaud merged 15 commits into
masterfrom
c2c-434

Conversation

@VaishSiddharth
Copy link
Copy Markdown
Contributor

@VaishSiddharth VaishSiddharth changed the title C2C-434: Show list of patients in MSPP Family planning report [WIP] C2C-434: Show list of patients in MSPP Family planning report Dec 22, 2025
@VaishSiddharth VaishSiddharth changed the title [WIP] C2C-434: Show list of patients in MSPP Family planning report C2C-434: Show list of patients in MSPP Family planning report Dec 24, 2025
Copy link
Copy Markdown

@kipchubett kipchubett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise looks good.

Comment on lines 33 to 35
super();
// TODO Auto-generated constructor stub
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
super();
// TODO Auto-generated constructor stub
}
super();
}

What's left to do here?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need this anymore?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No all the sql logic is now in java classes so that CohortCrossTabDataSetDefinition could be used for drilling down to patient list.

@kdaud kdaud merged commit 73fd0fe into master Jan 20, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants