Provider Roles domain needs to support addition of feature to core in 2.8+

[mseaton]

The existing providerroles domain was initially created to support configuing provider roles supported by the providermanagement module. In OpenMRS 2.8, ProviderRole was added to core, and when running against this version, providermanagement is no longer supported.

This ticket aims to update the providerroles domain to support either updating the providermanagement_provider_role table if running providermanagement and OpenMRS < 2.8, or updating the provider_role table if running OpenMRS 2.8+.

@ibacher or others, thoughts welcome.

[mseaton]

This could be somewhat tricky to implement in Initializer - not because the logic is complicated - but because of all of the variations of OpenMRS and module versions that are currently supported.

[mseaton]

I made a few attempts to see if I could code this up quickly, by adding support for the new ProviderRole object into an api-2.8 submodule, and then either leaving the existing code alone, or moving it into a providermanagment submodule, but in both cases I ran into various conflicts. The fact that emrapi is also a dependency for some domains (dispositions) also complicates things. For now, I have just added support for this into our distribution module so we can get on with things, but would be great to see if someone else feels like picking this up. See here:

https://github.com/PIH/openmrs-module-pihcore/tree/master/api/src/main/java/org/openmrs/module/pihcore/initializer/providerroles

@ibacher FYI

[ibacher]

Has provider management itself been updated for 2.8? I'm sort of wondering if we can leave the existing domain as-is and create a new one for 2.8.x with something like @OpenmrsProfile(openmrsPlatformVersion = "2.8.x", modules = { "!providermanagement:*" }).

[mseaton]

Has provider management itself been updated for 2.8

After some efforts of attempting this, I abandoned it, as although I was able to finally get things somewhat working, it didn't really achieve my end goal of doing so to retain backwards compatibility with modules that had depending upon it.

At the end of the day, we reviewed the functionality that the module was providing above the core, minimalist ProviderRole object that was moved to core, and it wasn't providing anything that any of our implementations actually used, and on the UI-side, the pages kind-of work maybe even in the current version, but not in a way that makes me think that anyone is actually using these seriously in production for anything. So my conclusion is that we simply drop the providermanagement module from support entirely from OpenMRS 2.8+. See https://openmrs.atlassian.net/browse/PROV-112. Also see what seems like the same conclusions that Wikum drew in his earlier PR here: openmrs/openmrs-module-providermanagement#54