Bump Biome 2.4, ESLint 10, TypeScript 6; fix lint and type errors

obiot · claude · obiot · commit 9d3a18b5c844 · 2026-03-30T09:15:30.000+08:00
- Biome: 2.3.14 → 2.4.9
- ESLint: 9.x → 10.x (new no-useless-assignment rule)
- TypeScript: 5.9 → 6.0 (requires explicit rootDir in tsconfig)
- Fix all no-useless-assignment lint errors across the codebase
- Fix TS6 globalThis indexing in platform.ts
- Add rootDir to all tsconfig.build.json files
- Add VertexArrayBuffer unit tests for push() and pushFloats()

Co-Authored-By: Claude Opus 4.6 (1M context) &lt;noreply@anthropic.com&gt;
diff --git a/package.json b/package.json
@@ -22,19 +22,19 @@
 	},
 	"packageManager": "pnpm@10.32.1",
 	"dependencies": {
-		"@biomejs/biome": "2.3.14",
-		"@eslint/js": "^9.39.4",
+		"@biomejs/biome": "2.4.9",
+		"@eslint/js": "^10.0.1",
 		"@types/node": "^25.5.0",
 		"@vitest/browser": "^4.1.2",
 		"@vitest/browser-playwright": "^4.1.2",
-		"eslint": "^9.39.4",
+		"eslint": "^10.1.0",
 		"eslint-plugin-jsdoc": "^62.8.1",
 		"globals": "^17.4.0",
 		"lefthook": "^2.1.4",
 		"tsconfig": "workspace:^",
 		"tsx": "^4.21.0",
 		"turbo": "^2.8.21",
-		"typescript": "^5.9.3",
+		"typescript": "^6.0.2",
 		"typescript-eslint": "^8.57.2",
 		"vitest": "^4.1.2"
 	},
diff --git a/packages/debug-plugin/package.json b/packages/debug-plugin/package.json
@@ -51,7 +51,7 @@
 		"melonjs": "workspace:*",
 		"tsconfig": "workspace:*",
 		"tsx": "^4.21.0",
-		"typescript": "^5.9.3"
+		"typescript": "^6.0.2"
 	},
 	"scripts": {
 		"dev": "concurrently --raw \"pnpm build:watch\" \"pnpm tsc:watch\"",
diff --git a/packages/debug-plugin/tsconfig.build.json b/packages/debug-plugin/tsconfig.build.json
@@ -1,6 +1,7 @@
 {
 	"extends": "tsconfig/base.json",
 	"compilerOptions": {
+		"rootDir": "src",
 		"declarationDir": "build",
 		"removeComments": false,
 		"declarationMap": true,
diff --git a/packages/examples/package.json b/packages/examples/package.json
@@ -21,7 +21,7 @@
 		"react-dom": "^19.2.4",
 		"react-router-dom": "^7.13.2",
 		"tsconfig": "workspace:^",
-		"typescript": "^5.9.3",
+		"typescript": "^6.0.2",
 		"vite": "8.0.0"
 	}
 }
diff --git a/packages/melonjs/package.json b/packages/melonjs/package.json
@@ -69,7 +69,7 @@
 		"tsx": "^4.21.0",
 		"type-fest": "^5.5.0",
 		"typedoc": "^0.28.18",
-		"typescript": "^5.9.3",
+		"typescript": "^6.0.2",
 		"vite": "8.0.0",
 		"vite-plugin-glsl": "^1.5.6"
 	},
diff --git a/packages/melonjs/src/geometries/path2d.js b/packages/melonjs/src/geometries/path2d.js
@@ -84,7 +84,7 @@ class Path2D {
 		const pathCommands = svgPath.match(/([a-df-z])[^a-df-z]*/gi);
 		const points = this.points;
 		const startPoint = this.startPoint;
-		let lastPoint = startPoint;
+		let lastPoint;
 
 		this.beginPath();
 
diff --git a/packages/melonjs/src/input/pointerevent.ts b/packages/melonjs/src/input/pointerevent.ts
@@ -335,7 +335,6 @@ function dispatchEvent(normalizedEvents: Pointer[]): boolean {
 				const region = handlers.region;
 				const ancestor = region.ancestor;
 				const bounds = region.getBounds();
-				let eventInBounds = false;
 
 				if (region.isFloating === true) {
 					pointer.gameX = pointer.gameLocalX = pointer.gameScreenX;
@@ -353,7 +352,7 @@ function dispatchEvent(normalizedEvents: Pointer[]): boolean {
 					pointer.gameLocalY = pointer.gameY - parentBounds.y;
 				}
 
-				eventInBounds = bounds.contains(pointer.gameX, pointer.gameY);
+				const eventInBounds = bounds.contains(pointer.gameX, pointer.gameY);
 
 				switch (pointer.type) {
 					case POINTER_MOVE[0]:
diff --git a/packages/melonjs/src/level/tiled/TMXTileMap.js b/packages/melonjs/src/level/tiled/TMXTileMap.js
@@ -455,7 +455,6 @@ export default class TMXTileMap {
 	 */
 	getObjects(flatten) {
 		const objects = [];
-		let isCollisionGroup = false;
 		let targetContainer;
 
 		// parse the map for objects
@@ -465,7 +464,9 @@ export default class TMXTileMap {
 			const group = this.objectGroups[g];
 
 			// check if this is the collision shape group
-			isCollisionGroup = group.name.toLowerCase().includes(COLLISION_GROUP);
+			const isCollisionGroup = group.name
+				.toLowerCase()
+				.includes(COLLISION_GROUP);
 
 			if (flatten === false) {
 				// create a new container
diff --git a/packages/melonjs/src/loader/loader.js b/packages/melonjs/src/loader/loader.js
@@ -170,7 +170,7 @@ export let onload;
  * // use the LOADER_PROGRESS event instead
  * me.event.on(me.event.LOADER_PROGRESS, (progress, resource) => this.updateProgress(progress, resource));
  */
-export let onProgress;
+export let onProgress; // eslint-disable-line no-unassigned-vars
 
 /**
  * onError callback<br>
diff --git a/packages/melonjs/src/physics/quadtree.js b/packages/melonjs/src/physics/quadtree.js
@@ -237,11 +237,9 @@ export default class QuadTree {
 	 * @param {object} item - object to be added
 	 */
 	insert(item) {
-		let index = -1;
-
 		//if we have subnodes ...
 		if (this.nodes.length > 0) {
-			index = this.getIndex(item);
+			const index = this.getIndex(item);
 
 			if (index !== -1) {
 				this.nodes[index].insert(item);
@@ -263,9 +261,9 @@ export default class QuadTree {
 			//add all objects to their corresponding subnodes
 			let writeIdx = 0;
 			for (let i = 0, len = this.objects.length; i < len; i++) {
-				index = this.getIndex(this.objects[i]);
-				if (index !== -1) {
-					this.nodes[index].insert(this.objects[i]);
+				const subIndex = this.getIndex(this.objects[i]);
+				if (subIndex !== -1) {
+					this.nodes[subIndex].insert(this.objects[i]);
 				} else {
 					this.objects[writeIdx++] = this.objects[i];
 				}
diff --git a/packages/melonjs/src/physics/sat.js b/packages/melonjs/src/physics/sat.js
@@ -130,7 +130,7 @@ function isSeparatingAxis(aPos, bPos, aPoints, bPoints, axis, response) {
 
 	// This is not a separating axis. If we're calculating a response, calculate the overlap.
 	if (response) {
-		let overlap = 0;
+		let overlap;
 		// A starts further left than B
 		if (rangeA[0] < rangeB[0]) {
 			response.aInB = false;
@@ -366,7 +366,7 @@ export function testPolygonEllipse(a, polyA, b, ellipseB, response) {
 	const edge = T_VECTORS[--T_VECTORS_IDX];
 	const normal = T_VECTORS[--T_VECTORS_IDX];
 	const point = T_VECTORS[--T_VECTORS_IDX];
-	let dist = 0;
+	let dist;
 
 	// For each edge in the polygon:
 	for (let i = 0; i < len; i++) {
diff --git a/packages/melonjs/src/renderable/container.js b/packages/melonjs/src/renderable/container.js
@@ -931,7 +931,6 @@ export default class Container extends Renderable {
 	 * @param {Camera2d} [viewport] - the viewport to (re)draw
 	 */
 	draw(renderer, viewport) {
-		let isFloating = false;
 		const bounds = this.getBounds();
 
 		this.drawCount = 0;
@@ -958,7 +957,7 @@ export default class Container extends Renderable {
 		const children = this.getChildren();
 		for (let i = children.length, obj; i--, (obj = children[i]); ) {
 			if (obj.isRenderable) {
-				isFloating = obj.floating === true;
+				const isFloating = obj.floating === true;
 
 				if (obj.inViewport || isFloating) {
 					// skip UI-only floating elements on non-default cameras
diff --git a/packages/melonjs/src/renderable/text/bitmaptextdata.ts b/packages/melonjs/src/renderable/text/bitmaptextdata.ts
@@ -124,7 +124,7 @@ export default class BitmapTextData {
 		const baseLine = parseFloat(getValueFromPair(lines[1], /base=\d+/g));
 		const padY = this.padTop + this.padBottom;
 
-		let glyph: Glyph | null = null;
+		let glyph: Glyph | null | undefined;
 
 		for (let i = 4; i < lines.length; i++) {
 			const line = lines[i];
diff --git a/packages/melonjs/src/system/device.js b/packages/melonjs/src/system/device.js
@@ -725,14 +725,13 @@ export function getParentBounds(element) {
  */
 export function isWebGLSupported(options) {
 	if (WebGLSupport === -1) {
-		let _supported = false;
 		try {
 			const canvas = globalThis.document.createElement("canvas");
 			const ctxOptions = {
 				stencil: true,
 				failIfMajorPerformanceCaveat: options.failIfMajorPerformanceCaveat,
 			};
-			_supported = !!(
+			const _supported = !!(
 				globalThis.WebGLRenderingContext &&
 				(canvas.getContext("webgl", ctxOptions) ||
 					canvas.getContext("experimental-webgl", ctxOptions))
diff --git a/packages/melonjs/src/system/platform.ts b/packages/melonjs/src/system/platform.ts
@@ -33,9 +33,12 @@ export const Kindle = /Kindle|Silk.*Mobile Safari/i.test(ua);
 export const ejecta = "ejecta" in globalThis;
 export const isWeixin = /MicroMessenger/i.test(ua);
 export const nodeJS =
-	typeof globalThis.process !== "undefined" &&
-	typeof globalThis.process.release !== "undefined" &&
-	globalThis.process.release.name === "node";
+	typeof (globalThis as unknown as { process?: { release?: { name: string } } })
+		.process !== "undefined" &&
+	typeof (globalThis as unknown as { process?: { release?: { name: string } } })
+		.process?.release !== "undefined" &&
+	(globalThis as unknown as { process?: { release?: { name: string } } })
+		.process?.release?.name === "node";
 export const isMobile =
 	/Mobi/i.test(ua) || iOS || android || wp || BlackBerry || Kindle || false;
 export const webApp =
diff --git a/packages/melonjs/src/video/webgl/buffer/vertex.js b/packages/melonjs/src/video/webgl/buffer/vertex.js
@@ -43,13 +43,13 @@ export default class VertexArrayBuffer {
 	 * @ignore
 	 */
 	push(x, y, u, v, tint) {
-		let offset = this.vertexCount * this.vertexSize;
+		const offset = this.vertexCount * this.vertexSize;
 
 		this.bufferF32[offset] = x;
-		this.bufferF32[++offset] = y;
-		this.bufferF32[++offset] = u;
-		this.bufferF32[++offset] = v;
-		this.bufferU32[++offset] = tint;
+		this.bufferF32[offset + 1] = y;
+		this.bufferF32[offset + 2] = u;
+		this.bufferF32[offset + 3] = v;
+		this.bufferU32[offset + 4] = tint;
 
 		this.vertexCount++;
 
diff --git a/packages/melonjs/src/video/webgl/utils/program.js b/packages/melonjs/src/video/webgl/utils/program.js
@@ -21,7 +21,7 @@ export function compileProgram(gl, vertex, fragment, attributes) {
 	const vertShader = compileShader(gl, gl.VERTEX_SHADER, vertex);
 	const fragShader = compileShader(gl, gl.FRAGMENT_SHADER, fragment);
 
-	let program = gl.createProgram();
+	const program = gl.createProgram();
 
 	gl.attachShader(program, vertShader);
 	gl.attachShader(program, fragShader);
@@ -49,7 +49,6 @@ export function compileProgram(gl, vertex, fragment, attributes) {
 			gl.getProgramInfoLog(program);
 		// house cleaning
 		gl.deleteProgram(program);
-		program = null;
 		// throw the exception
 		throw new Error(error_msg);
 	}
diff --git a/packages/melonjs/tests/ui.spec.js b/packages/melonjs/tests/ui.spec.js
@@ -274,12 +274,10 @@ describe("UI", () => {
 					// stopping just before `new BitmapText(...)`.
 					this.bindKey = settings.bindKey || -1;
 
-					/* eslint-disable no-prototype-builtins */
 					this.hoverOffColor =
 						settings.hoverOffColor || settings.backgroundColor || "#00aa0080";
 					this.hoverOnColor =
 						settings.hoverOnColor || settings.hoverColor || "#00ff00ff";
-					/* eslint-enable no-prototype-builtins */
 
 					this.borderStrokeColor = settings.borderStrokeColor || "#000000";
 					this.textAlign = settings.textAlign || "center";
diff --git a/packages/melonjs/tests/vertexBuffer.spec.js b/packages/melonjs/tests/vertexBuffer.spec.js
@@ -0,0 +1,86 @@
+import { describe, expect, it } from "vitest";
+import VertexArrayBuffer from "../src/video/webgl/buffer/vertex.js";
+
+describe("VertexArrayBuffer", () => {
+	describe("push()", () => {
+		it("should write vertex data at the correct offsets", () => {
+			// vertexSize=5 matches the quad format: x, y, u, v, tint
+			const buf = new VertexArrayBuffer(5, 4);
+
+			buf.push(10, 20, 0.0, 1.0, 0xffffffff);
+
+			expect(buf.vertexCount).toBe(1);
+			expect(buf.bufferF32[0]).toBe(10); // x
+			expect(buf.bufferF32[1]).toBe(20); // y
+			expect(buf.bufferF32[2]).toBe(0.0); // u
+			expect(buf.bufferF32[3]).toBe(1.0); // v
+			expect(buf.bufferU32[4]).toBe(0xffffffff); // tint
+		});
+
+		it("should write multiple vertices sequentially", () => {
+			const buf = new VertexArrayBuffer(5, 4);
+
+			buf.push(1, 2, 0.0, 0.0, 0xff000000);
+			buf.push(3, 4, 1.0, 1.0, 0x00ff0000);
+
+			expect(buf.vertexCount).toBe(2);
+			// second vertex starts at offset 5
+			expect(buf.bufferF32[5]).toBe(3); // x
+			expect(buf.bufferF32[6]).toBe(4); // y
+			expect(buf.bufferF32[7]).toBe(1.0); // u
+			expect(buf.bufferF32[8]).toBe(1.0); // v
+			expect(buf.bufferU32[9]).toBe(0x00ff0000); // tint
+		});
+	});
+
+	describe("pushFloats()", () => {
+		it("should copy float data for a single vertex", () => {
+			const buf = new VertexArrayBuffer(4, 4);
+			const data = new Float32Array([10, 20, 0.5, 0.5]);
+
+			buf.pushFloats(data, 0, 4);
+
+			expect(buf.vertexCount).toBe(1);
+			expect(buf.bufferF32[0]).toBe(10);
+			expect(buf.bufferF32[1]).toBe(20);
+			expect(buf.bufferF32[2]).toBe(0.5);
+			expect(buf.bufferF32[3]).toBe(0.5);
+		});
+
+		it("should copy from a source offset", () => {
+			const buf = new VertexArrayBuffer(3, 4);
+			const data = new Float32Array([99, 99, 99, 1, 2, 3]);
+
+			buf.pushFloats(data, 3, 3);
+
+			expect(buf.vertexCount).toBe(1);
+			expect(buf.bufferF32[0]).toBe(1);
+			expect(buf.bufferF32[1]).toBe(2);
+			expect(buf.bufferF32[2]).toBe(3);
+		});
+	});
+
+	describe("isFull()", () => {
+		it("should return true when adding vertices would exceed capacity", () => {
+			const buf = new VertexArrayBuffer(5, 2);
+
+			expect(buf.isFull(2)).toBe(true);
+			expect(buf.isFull(1)).toBe(false);
+
+			buf.push(0, 0, 0, 0, 0);
+			expect(buf.isFull(1)).toBe(true);
+		});
+	});
+
+	describe("clear()", () => {
+		it("should reset vertex count to zero", () => {
+			const buf = new VertexArrayBuffer(5, 4);
+
+			buf.push(1, 2, 3, 4, 0);
+			expect(buf.vertexCount).toBe(1);
+
+			buf.clear();
+			expect(buf.vertexCount).toBe(0);
+		});
+	});
+});
diff --git a/packages/melonjs/tsconfig.build.json b/packages/melonjs/tsconfig.build.json
@@ -1,6 +1,7 @@
 {
 	"extends": "tsconfig/base.json",
 	"compilerOptions": {
+		"rootDir": "src",
 		"declarationDir": "build",
 		"removeComments": false,
 		"declarationMap": true,
diff --git a/packages/spine-plugin/package.json b/packages/spine-plugin/package.json
@@ -60,7 +60,7 @@
 		"melonjs": "workspace:*",
 		"tsconfig": "workspace:*",
 		"tsx": "^4.21.0",
-		"typescript": "^5.9.3"
+		"typescript": "^6.0.2"
 	},
 	"scripts": {
 		"dev": "concurrently --raw \"pnpm build:watch\" \"pnpm tsc:watch\"",
diff --git a/packages/spine-plugin/tsconfig.build.json b/packages/spine-plugin/tsconfig.build.json
@@ -1,6 +1,7 @@
 {
 	"extends": "tsconfig/base.json",
 	"compilerOptions": {
+		"rootDir": "src",
 		"declarationDir": "build",
 		"removeComments": false,
 		"declarationMap": true,
diff --git a/packages/tiled-inflate-plugin/package.json b/packages/tiled-inflate-plugin/package.json
@@ -53,7 +53,7 @@
 		"melonjs": "workspace:*",
 		"tsconfig": "workspace:*",
 		"tsx": "^4.21.0",
-		"typescript": "^5.9.3"
+		"typescript": "^6.0.2"
 	},
 	"scripts": {
 		"build": "tsx scripts/build.ts && pnpm types",
diff --git a/packages/tiled-inflate-plugin/tsconfig.build.json b/packages/tiled-inflate-plugin/tsconfig.build.json
@@ -1,6 +1,7 @@
 {
 	"extends": "tsconfig/base.json",
 	"compilerOptions": {
+		"rootDir": "src",
 		"declarationDir": "build",
 		"removeComments": false,
 		"declarationMap": true,
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`{`
`2`	`2`	`"extends": "tsconfig/base.json",`
`3`	`3`	`"compilerOptions": {`
	`4`	`+ "rootDir": "src",`
`4`	`5`	`"declarationDir": "build",`
`5`	`6`	`"removeComments": false,`
`6`	`7`	`"declarationMap": true,`
Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@`
`21`	`21`	`"react-dom": "^19.2.4",`
`22`	`22`	`"react-router-dom": "^7.13.2",`
`23`	`23`	`"tsconfig": "workspace:^",`
`24`		`- "typescript": "^5.9.3",`
	`24`	`+ "typescript": "^6.0.2",`
`25`	`25`	`"vite": "8.0.0"`
`26`	`26`	`}`
`27`	`27`	`}`