Fix: Avoid unnecessary cloning in WSDLParserContext and update comments for clarity on resource tracking (#2879)

predic8 · web-flow · commit 227a2fb067e8 · 2026-03-19T13:25:44.000+01:00
diff --git a/core/src/main/java/com/predic8/membrane/core/util/wsdl/parser/WSDLParserContext.java b/core/src/main/java/com/predic8/membrane/core/util/wsdl/parser/WSDLParserContext.java
@@ -26,9 +26,10 @@ public WSDLParserContext definitions(Definitions definitions) {
     }
 
     public WSDLParserContext basePath(String basePath) {
-        var nextVisited = new ArrayList<>(visitedLocations);
-        nextVisited.add(basePath);
-        return new WSDLParserContext(definitions, resolver, basePath, nextVisited);
+        // visitedLocations is not cloned on purpose. It contains the list of all the
+        // Files that are already included or imported.
+        visitedLocations.add(basePath);
+        return new WSDLParserContext(definitions, resolver, basePath, visitedLocations);
     }
 
     public WSDLParserContext resolver(Resolver resolver) {

Original file line number	Diff line number	Diff line change
`@@ -26,9 +26,10 @@ public WSDLParserContext definitions(Definitions definitions) {`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`public WSDLParserContext basePath(String basePath) {`
`29`		`- var nextVisited = new ArrayList<>(visitedLocations);`
`30`		`- nextVisited.add(basePath);`
`31`		`- return new WSDLParserContext(definitions, resolver, basePath, nextVisited);`
	`29`	`+ // visitedLocations is not cloned on purpose. It contains the list of all the`
	`30`	`+ // Files that are already included or imported.`
	`31`	`+ visitedLocations.add(basePath);`
	`32`	`+ return new WSDLParserContext(definitions, resolver, basePath, visitedLocations);`
`32`	`33`	`}`
`33`	`34`
`34`	`35`	`public WSDLParserContext resolver(Resolver resolver) {`