OK response (#2856)

predic8 · web-flow · commit 7a5893cb671d · 2026-03-06T17:22:06.000+01:00
* fix(core): standardize "OK" status message across HTTP responses and tests

* test(core): remove unused exceptions in `ResponseTest` methods

* test(core): standardize "OK" casing in tests and update copyright headers

- Corrected instances of "Ok" to "OK" in test assertions for consistency.
- Added missing copyright header to `BodyDoesntThrowIOExceptionTest`.
- Minor cleanup in `LargeBodyTest` to use `var` for improved readability.
diff --git a/core/src/main/java/com/predic8/membrane/core/util/HttpUtil.java b/core/src/main/java/com/predic8/membrane/core/util/HttpUtil.java
@@ -177,7 +177,7 @@ public static boolean isAbsoluteURI(String uri) {
 	public static String getMessageForStatusCode(int code) {
 		return switch (code) {
 			case 100 -> "Continue";
-			case 200 -> "Ok";
+			case 200 -> "OK";
 			case 201 -> "Created";
 			case 202 -> "Accepted";
 			case 204 -> "No Content";
diff --git a/core/src/test/java/com/predic8/membrane/core/http/ResponseTest.java b/core/src/test/java/com/predic8/membrane/core/http/ResponseTest.java
@@ -193,12 +193,12 @@ void testWithNoContentLength() throws Exception {
     }
 
     @Test
-    void isEmpty() throws IOException {
+    void isEmpty() {
         assertTrue(ok().build().isBodyEmpty());
     }
 
     @Test
-    void isNotEmpty() throws Exception {
+    void isNotEmpty() {
         assertFalse(ok("ABC").build().isBodyEmpty());
     }
 
@@ -218,7 +218,7 @@ void statusCodeBuilders(ResponseBuilder builder, int statusCode, String msg, boo
     private static Stream<Arguments> statusCodeMessageGenerator() {
         return Stream.of(
             // Do not check body
-            of(ok(), 200, "Ok", false),
+            of(ok(), 200, "OK", false),
             of(noContent(), 204, "No Content", false),
             of(forbidden(), 403, "Forbidden", false),
             of(continue100(), 100, "Continue", false),
@@ -251,7 +251,7 @@ void fromStatusCodeTest() {
         assertEquals(200,response.getStatusCode());
         assertTrue(isOfMediaType( TEXT_HTML,response.getHeader().getContentType()));
         assertEquals("""
-                <html><head><title>200 Ok.</title></head><body><h1>200 Ok.</h1><p>The Message <b>is</b> this!</p></body></html>""",
+                <html><head><title>200 OK.</title></head><body><h1>200 OK.</h1><p>The Message <b>is</b> this!</p></body></html>""",
                 response.getBodyAsStringDecoded());
     }
 
diff --git a/core/src/test/java/com/predic8/membrane/core/interceptor/oauth2/client/b2c/OAuth2ResourceB2CUnitTest.java b/core/src/test/java/com/predic8/membrane/core/interceptor/oauth2/client/b2c/OAuth2ResourceB2CUnitTest.java
@@ -383,7 +383,7 @@ void loginNotRequired() throws Exception {
         var exc = browser.applyWithoutRedirect(get(tc.getClientAddress() + "/api-no-auth-needed/"));
 
         assertEquals(200, exc.getResponse().getStatusCode());
-        assertEquals("Ok", exc.getResponse().getStatusMessage());
+        assertEquals("OK", exc.getResponse().getStatusMessage());
         var res = om.readValue(exc.getResponse().getBodyAsStringDecoded(), Map.class);
         assertEquals("null", res.get("accessToken"));
 
@@ -392,7 +392,7 @@ void loginNotRequired() throws Exception {
         // access 2: authenticated, expecting JWT
         exc = browser.applyWithoutRedirect(get(tc.getClientAddress() + "/api-no-auth-needed/"));
         assertEquals(200, exc.getResponse().getStatusCode());
-        assertEquals("Ok", exc.getResponse().getStatusMessage());
+        assertEquals("OK", exc.getResponse().getStatusMessage());
         res = om.readValue(exc.getResponse().getBodyAsStringDecoded(), Map.class);
         assertTrue(((String)res.get("accessToken")).startsWith("eyJ"));
     }
@@ -411,7 +411,7 @@ void returning4xx() throws Exception {
         // access 2: authenticated, expecting JWT
         exc = browser.applyWithoutRedirect(get(tc.getClientAddress() + "/api-no-redirect/"));
         assertEquals(200, exc.getResponse().getStatusCode());
-        assertEquals("Ok", exc.getResponse().getStatusMessage());
+        assertEquals("OK", exc.getResponse().getStatusMessage());
         var res = om.readValue(exc.getResponse().getBodyAsStringDecoded(), Map.class);
         assertTrue(((String)res.get("accessToken")).startsWith("eyJ"));
     }
diff --git a/core/src/test/java/com/predic8/membrane/integration/withinternet/LargeBodyTest.java b/core/src/test/java/com/predic8/membrane/integration/withinternet/LargeBodyTest.java
@@ -28,6 +28,7 @@
 import java.util.concurrent.atomic.*;
 
 import static com.predic8.membrane.core.http.Header.*;
+import static com.predic8.membrane.core.http.Request.post;
 import static com.predic8.membrane.core.http.Response.*;
 import static com.predic8.membrane.core.interceptor.Outcome.*;
 import static java.lang.Integer.*;
@@ -109,8 +110,8 @@ public void large() throws Exception {
     public void largeChunked() throws Exception {
         long len = MAX_VALUE + 1L;
 
-        Exchange e = new Request.Builder().post("http://localhost:3041/foo").body(len, new ConstantInputStream(len)).header(TRANSFER_ENCODING, CHUNKED).buildExchange();
-        try (HttpClient hc = new HttpClient(hcc)) {
+        var e = post("http://localhost:3041/foo").body(len, new ConstantInputStream(len)).header(TRANSFER_ENCODING, CHUNKED).buildExchange();
+        try (var hc = new HttpClient(hcc)) {
             hc.call(e);
         }
         assertTrue(e.getRequest().getBody().wasStreamed());
diff --git a/core/src/test/java/com/predic8/membrane/integration/withoutinternet/interceptor/oauth2/OAuth2Test.java b/core/src/test/java/com/predic8/membrane/integration/withoutinternet/interceptor/oauth2/OAuth2Test.java
@@ -97,7 +97,7 @@ void jwtAuthentication() throws Exception {
         JSONObject jsonObject = new JSONObject(json);
         assertEquals("Bearer", jsonObject.getString("token_type"));
         assertNotNull(jsonObject.getString("access_token"));
-        assertEquals("Ok", sendRequestToTarget(parseTokenRequestResponse("access_token", json)));
+        assertEquals("OK", sendRequestToTarget(parseTokenRequestResponse("access_token", json)));
     }
 
     @Test
@@ -114,7 +114,7 @@ void testJwtAuthenticationAfterRefresh() throws Exception {
 
         assertEquals("Bearer", jsonObject.getString("token_type"));
         assertNotNull(jsonObject.getString("access_token"));
-        assertEquals("Ok", sendRequestToTarget(parseTokenRequestResponse("access_token", json)));
+        assertEquals("OK", sendRequestToTarget(parseTokenRequestResponse("access_token", json)));
 
         assertEquals(getJwtClaim(at1, "iss"), getJwtClaim(at2, "iss"));
         assertEquals(getJwtClaim(at1, "sub"), getJwtClaim(at2, "sub"));
diff --git a/distribution/src/test/java/com/predic8/membrane/examples/withoutinternet/test/OAuth2CredentialsExampleTest.java b/distribution/src/test/java/com/predic8/membrane/examples/withoutinternet/test/OAuth2CredentialsExampleTest.java
@@ -57,7 +57,7 @@ void testIt() throws Exception {
                 .withWatcher(logger)
                 .script("client")
                 .withParameters("john password")
-                .waitAfterStartFor("Ok")
+                .waitAfterStartFor("OK")
                 .start()) {
             assertTrue(true);
         }

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ void testIt() throws Exception {`
`57`	`57`	`.withWatcher(logger)`
`58`	`58`	`.script("client")`
`59`	`59`	`.withParameters("john password")`
`60`		`- .waitAfterStartFor("Ok")`
	`60`	`+ .waitAfterStartFor("OK")`
`61`	`61`	`.start()) {`
`62`	`62`	`assertTrue(true);`
`63`	`63`	`}`