Call: handle Abort (#2675)

* feat(dispatcher): add production mode support for error handling and extend URI validation tests

- Introduced `productionRouter` in `DummyTestRouter` to enable production mode configuration.
- Updated `DispatchingInterceptor` to adjust error messages in production mode.
- Expanded `DispatchingInterceptorTest` with production-specific URI validation.

* `refactor(core): simplify type declaration and enhance error handling in CallInterceptor`

Author: predic8

core/src/main/java/com/predic8/membrane/core/interceptor/flow/CallInterceptor.java

@@ -13,34 +13,29 @@
    limitations under the License. */
 package com.predic8.membrane.core.interceptor.flow;
 
-import com.predic8.membrane.annot.MCAttribute;
-import com.predic8.membrane.annot.MCElement;
-import com.predic8.membrane.annot.Required;
-import com.predic8.membrane.core.exchange.Exchange;
-import com.predic8.membrane.core.http.Header;
-import com.predic8.membrane.core.http.HeaderField;
-import com.predic8.membrane.core.http.Request;
-import com.predic8.membrane.core.interceptor.Outcome;
-import com.predic8.membrane.core.interceptor.lang.AbstractExchangeExpressionInterceptor;
-import com.predic8.membrane.core.transport.http.HttpClient;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-import java.io.IOException;
-import java.util.Arrays;
-import java.util.List;
+import com.predic8.membrane.annot.*;
+import com.predic8.membrane.core.exceptions.*;
+import com.predic8.membrane.core.exchange.*;
+import com.predic8.membrane.core.http.*;
+import com.predic8.membrane.core.interceptor.*;
+import com.predic8.membrane.core.interceptor.lang.*;
+import com.predic8.membrane.core.transport.http.*;
+import org.slf4j.*;
+
+import java.io.*;
+import java.net.*;
+import java.util.*;
 
 import static com.google.api.client.http.HttpMethods.*;
-import static com.predic8.membrane.core.exceptions.ProblemDetails.internal;
+import static com.predic8.membrane.core.exceptions.ProblemDetails.*;
 import static com.predic8.membrane.core.http.Header.*;
-import static com.predic8.membrane.core.interceptor.Interceptor.Flow.REQUEST;
+import static com.predic8.membrane.core.interceptor.Interceptor.Flow.*;
+import static com.predic8.membrane.core.interceptor.Outcome.*;
 import static com.predic8.membrane.core.interceptor.Outcome.ABORT;
-import static com.predic8.membrane.core.interceptor.Outcome.CONTINUE;
-import static java.util.Collections.singletonList;
+import static java.util.Collections.*;
 
 /**
  * @description Calls an external endpoint
- *
  * @topic 1. Proxies and Flow
  */
 @MCElement(name = "call")
@@ -81,8 +76,15 @@ private Outcome handleInternal(Exchange exc) {
 
         try (HttpClient client = new HttpClient()) {
             client.call(newExc);
+        } catch (UnknownHostException e) {
+            log.error("Error calling: {} Unknown host: {}", dest, e.getMessage());
+            createProblemDetails(dest)
+                    .detail("Unknown host " + e.getMessage())
+                    .buildAndSetResponse(exc);
+            return ABORT;
         } catch (Exception e) {
             log.error("Error during HTTP call to {}: {}", dest, e.getMessage(), e);
+            createProblemDetails(dest).buildAndSetResponse(exc);
             return ABORT;
         }
 
@@ -105,6 +107,13 @@ private Outcome handleInternal(Exchange exc) {
         }
     }
 
+    private ProblemDetails createProblemDetails(String dest) {
+        return internal(router.getConfiguration().isProduction(), "call")
+                .title("Error performing callout.")
+                .internal("expression", exchangeExpression.getExpression())
+                .internal("destination", dest);
+    }
+
     private Request getNewRequest(Exchange exchange) {
         Request.Builder builder = new Request.Builder()
                 .method(method)
@@ -145,7 +154,7 @@ Header getFilteredRequestHeader(Exchange exc) {
             requestHeader.add(field.getHeaderName().getName(), field.getValue());
         }
         // Removes body-related headers when no body is present
-        if(!methodShouldHaveBody(method)) {
+        if (!methodShouldHaveBody(method)) {
             requestHeader.removeFields(CONTENT_TYPE);
             requestHeader.removeFields(CONTENT_LENGTH);
             requestHeader.removeFields(TRANSFER_ENCODING);
@@ -161,7 +170,7 @@ static void copyHeadersFromResponseToRequest(Exchange responseExc, Exchange orig
                 if (headerField.getHeaderName().getName().equalsIgnoreCase(rmHeader))
                     return;
             }
-            originalExc.getRequest().getHeader().setValue(headerField.getHeaderName().getName(),headerField.getValue());
+            originalExc.getRequest().getHeader().setValue(headerField.getHeaderName().getName(), headerField.getValue());
         });
     }
 

core/src/main/java/com/predic8/membrane/core/lang/spel/SpELExchangeEvaluationContext.java

@@ -95,7 +95,7 @@ public SpELExchangeEvaluationContext(Exchange exchange, Flow flow) {
     }
 
     private void addTypeConverters() {
-        GenericConversionService cs = new DefaultConversionService();
+        var cs = new DefaultConversionService();
         cs.addConverter(new SpELMapToStringTypeConverter());
         cs.addConverter(new SpELBodyToStringTypeConverter());
         cs.addConverter(new ListToStringTypeConverter());