Skip to content

fix example http request#2235

Merged
t-burch merged 2 commits into
masterfrom
example-fix
Oct 20, 2025
Merged

fix example http request#2235
t-burch merged 2 commits into
masterfrom
example-fix

Conversation

@russelmrcl
Copy link
Copy Markdown
Contributor

@russelmrcl russelmrcl commented Oct 20, 2025

Summary by CodeRabbit

  • Documentation
    • Updated the OAuth2 token example to use a single-line URL-encoded POST body, consolidating parameters for clearer, more consistent request formatting.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Oct 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updated an OAuth2 token example request: the POST body for /oauth2/token was changed from multi-line form fields to a single-line URL-encoded body containing grant_type, username, password, client_id, and client_secret.

Changes

Cohort / File(s) Summary
OAuth2 example HTTP request formatting
distribution/examples/security/oauth2/api/rest.http
Replaced multi-line form fields with a single-line URL-encoded body (grant_type=password&username=john&password=password&client_id=abc&client_secret=def) for the POST /oauth2/token request.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • predic8

Poem

🐰 A tiny tweak, a tidy little art,
Fields once scattered, now snug from the start.
One line to rule the token request bright,
Hops of approval in morning's soft light.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "fix example http request" directly and accurately describes the main change in the pull request. The changeset modifies a file in distribution/examples/security/oauth2/api/rest.http to correct the formatting of an HTTP POST request body. The title is concise, avoids noise, and clearly communicates to reviewers that this is a fix to an example HTTP request file. The title successfully summarizes the primary intent without needing to include implementation details like the reformatting from multi-line to single-line URL encoding.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 987ca04 and 349ad0c.

📒 Files selected for processing (1)
  • distribution/examples/security/oauth2/api/rest.http (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@membrane-ci-server
Copy link
Copy Markdown

This pull request needs "/ok-to-test" from an authorized committer.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3c78924 and 987ca04.

📒 Files selected for processing (1)
  • distribution/examples/security/oauth2/api/rest.http (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Analyze (java)

Comment thread distribution/examples/security/oauth2/api/rest.http Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@t-burch t-burch merged commit e7ea3c8 into master Oct 20, 2025
2 of 3 checks passed
@t-burch t-burch deleted the example-fix branch October 20, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants