Skip to content

disable ExampleUnitTests#2502

Merged
predic8 merged 3 commits into
masterfrom
fix-test-run
Dec 23, 2025
Merged

disable ExampleUnitTests#2502
predic8 merged 3 commits into
masterfrom
fix-test-run

Conversation

@christiangoerdes

@christiangoerdes christiangoerdes commented Dec 23, 2025

Copy link
Copy Markdown
Collaborator

We could remove this test. Currently only runs the ConfigSerializationTest which is also disabled

Summary by CodeRabbit

  • Tests

    • Removed test suite class to simplify test configuration and reduce infrastructure overhead.
  • Chores

    • Added Apache 2.0 license headers to multiple annotation processing source files for regulatory compliance.
    • Introduced new bean change event type to enable applications to track and respond to changes in bean definitions.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitai Bot commented Dec 23, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

This PR adds Apache 2.0 license headers to three bean registry classes (AsyncBeanCollector, BeanCollector, BeanContainer), introduces a new BeanDefinitionChanged event record to track bean definition changes with WatchAction and BeanDefinition fields, and removes an unused JUnit test suite class.

Changes

Cohort / File(s) Change Summary
License Header Additions
annot/src/main/java/com/predic8/membrane/annot/beanregistry/AsyncBeanCollector.java, BeanCollector.java, BeanContainer.java
Added standard Apache 2.0 license header comments; no logic or API changes
New Event Type
annot/src/main/java/com/predic8/membrane/annot/beanregistry/BeanDefinitionChanged.java
Introduced new public record BeanDefinitionChanged(WatchAction action, BeanDefinition bd) implementing ChangeEvent with supporting license header and import statement
Test Suite Removal
distribution/src/test/java/com/predic8/membrane/examples/ExampleUnitTests.java
Removed entire test suite class that aggregated ConfigSerializationTest via JUnit Platform Suite

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • split BeanRegistry interface #2488: Changes to the same beanregistry classes (AsyncBeanCollector, BeanCollector, BeanContainer, BeanDefinitionChanged), indicating overlapping modifications to the bean registry module.

Suggested reviewers

  • christiangoerdes
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix-test-run

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 78362ac and 4f4c5b7.

📒 Files selected for processing (5)
  • annot/src/main/java/com/predic8/membrane/annot/beanregistry/AsyncBeanCollector.java
  • annot/src/main/java/com/predic8/membrane/annot/beanregistry/BeanCollector.java
  • annot/src/main/java/com/predic8/membrane/annot/beanregistry/BeanContainer.java
  • annot/src/main/java/com/predic8/membrane/annot/beanregistry/BeanDefinitionChanged.java
  • distribution/src/test/java/com/predic8/membrane/examples/ExampleUnitTests.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@predic8 predic8 merged commit b73448e into master Dec 23, 2025
2 of 3 checks passed
@predic8 predic8 deleted the fix-test-run branch December 23, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants