update(roadmap): consolidate and prioritize goals across tutorials, Y…#2623
Conversation
…AML handling, and proxy/reuse performance improvements
📝 WalkthroughWalkthroughUpdated project roadmap document: reorganized and consolidated items into explicit PRIO 1, PRIO 2, and PRIO 3 sections; added and reclassified numerous task bullets related to tutorials, YAML handling, error messages, environment variables, publishing, and monitoring notes. Changes
Sequence Diagram(s)(omitted — changes are documentation-only and do not introduce new multi-component control flow) Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Fix all issues with AI agents
In `@docs/ROADMAP.md`:
- Line 35: Replace the misspelled word "Examle" with the correct spelling
"Example" in the ROADMAP document (look for the heading or line containing
"Examle" in docs/ROADMAP.md) so the text reads "Example".
- Line 46: Fix the typo in the ROADMAP text: change the phrase "Language is case
sensitve: e.g. language: SPEL is not valid according to the Schema and produces:
TB" to use "sensitive" instead of "sensitve" (update the sentence that starts
with "Language is case sensitve" in docs/ROADMAP.md).
- Line 43: Update the typo in the ROADMAP entry string "Migrate deprecated
finally to try with ressources" by replacing "ressources" with the correct
spelling "resources" so the line reads "Migrate deprecated finally to try with
resources".
- Line 21: Update the typo in the ROADMAP.md entry that currently reads "Central
desciption of MEMBRANE_* environment variables" to "Central description of
MEMBRANE_* environment variables" so the word "desciption" is corrected to
"description" in the document.
- Around line 22-23: Document all MEMBRANE_* environment variables grouped into
categories: installation/runtime (e.g., MEMBRANE_HOME, MEMBRANE_CALLER_DIR,
MEMBRANE_REQUIRED_JAVA_VERSION), logging/output (e.g.,
MEMBRANE_DISABLE_TERM_COLORS, MEMBRANE_TERM_COLORS, MEMBRANE_LOG_LEVEL),
feature-specific (e.g., MEMBRANE_VALIDATION, MEMBRANE_OAUTH, MEMBRANE_OTEL_*,
MEMBRANE_HTTPCLIENT_BUFFER_SIZE), and internal/generated (e.g.,
MEMBRANE_GENERATE_DOC_DIR, MEMBRANE_SCHEMA_JSON_FILENAME); for each variable
include purpose, default/expected values, validation rules, and example usage
snippets drawn from distribution scripts, and add a note/instruction that any
shell scripts referencing MEMBRANE_HOME must validate the directory contains
expected files (for example starter.jar) before proceeding to avoid runtime
errors.
🧹 Nitpick comments (1)
docs/ROADMAP.md (1)
18-18: Consider using markdown link syntax for the URL.The bare URL can be formatted as a markdown link for better readability and to satisfy markdown linting rules.
📝 Proposed formatting improvement
-- Register JSON Schema for YAML at: https://www.schemastore.org TB +- Register JSON Schema for YAML at [schemastore.org](https://www.schemastore.org) TB
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/ROADMAP.md
🧰 Additional context used
🪛 LanguageTool
docs/ROADMAP.md
[grammar] ~12-~12: Ensure spelling is correct
Context: ... run the tutorials in a Docker container - HotReload for YAML - YAML parsing: - Shorten YA...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~21-~21: Ensure spelling is correct
Context: ... Sheets, links to their docs. - Central desciption of MEMBRANE_* environment variables -...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~34-~34: Ensure spelling is correct
Context: ...es PRIO 3: - JMXExporter: - Tutorial - Examle - See JmxExporter - upgrade to jackson 3 ...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~43-~43: Ensure spelling is correct
Context: ... Migrate deprecated finally to try with ressources - YAML: - method: Suggest GET, POST, ......
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
[grammar] ~46-~46: Ensure spelling is correct
Context: ...est GET, POST, ... - Language is case sensitve: e.g. language: SPEL is not valid accord...
(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)
🪛 markdownlint-cli2 (0.18.1)
docs/ROADMAP.md
18-18: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (java)
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/ROADMAP.md (1)
63-63: Fix spelling error."Migraton Nots" should be "Migration Notes".
✏️ Proposed fix
-- Migraton Nots: +- Migration Notes:
🤖 Fix all issues with AI agents
In `@docs/ROADMAP.md`:
- Line 42: Remove the duplicate roadmap entry by deleting one of the two
identical lines that read "Discuss renaming the WebSocketInterceptor.flow to
something else to avoid confusion with flowParser"; ensure only a single
occurrence referencing WebSocketInterceptor.flow and flowParser remains in
ROADMAP.md so the task is not listed twice.
- Line 18: Replace the bare URL in the ROADMAP entry ("Register JSON Schema for
YAML at: https://www.schemastore.org TB") with a Markdown link; edit the line in
docs/ROADMAP.md (the entry containing "Register JSON Schema for YAML at:
https://www.schemastore.org TB") to use the format
[schemastore.org](https://www.schemastore.org) (and remove the stray "TB" if
it's not needed).
♻️ Duplicate comments (1)
docs/ROADMAP.md (1)
23-23: Rephrase the task description.The direct mention of
@coderabbitaiis inappropriate for a roadmap document. This should be reformulated as a proper task description.📝 Proposed fix
- - `@coderabbitai` look through the code base for usages of these variables and suggest documentation + - Document all MEMBRANE_* variables found in the codebase with usage examples
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/ROADMAP.md
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-02T18:05:47.059Z
Learnt from: rrayst
Repo: membrane/api-gateway PR: 1947
File: distribution/tutorials/soap/membrane.sh:17-22
Timestamp: 2025-07-02T18:05:47.059Z
Learning: When using environment variable shortcuts like `$MEMBRANE_HOME` in shell scripts that look for installation directories, validate that required files (like `starter.jar` for Membrane) exist in the candidate directory before returning it. This prevents hard-to-diagnose runtime errors when the environment variable points to an invalid or stale location.
Applied to files:
docs/ROADMAP.md
🪛 markdownlint-cli2 (0.18.1)
docs/ROADMAP.md
18-18: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (java)
🔇 Additional comments (1)
docs/ROADMAP.md (1)
9-32: Good reorganization of priorities.The consolidation into explicit PRIO 1, PRIO 2, and PRIO 3 sections significantly improves the roadmap's clarity and makes it easier to understand task prioritization.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
|
This pull request needs "/ok-to-test" from an authorized committer. |
…AML handling, and proxy/reuse performance improvements
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.