Update HttpTimeoutTest to expect 504 instead of 500 status code

[christiangoerdes]

Following the changes of 87dd5e9

Summary by CodeRabbit

• Bug Fixes
  • Corrected HTTP status code response when backend requests exceed the configured timeout threshold, now properly returning 504 Gateway Timeout instead of 500 Internal Server Error.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5aafb340-fcd6-4e21-8423-1a0e5a6bdc53

📥 Commits

Reviewing files that changed from the base of the PR and between 37eff25 and 41b94c5.

📒 Files selected for processing (1)

• core/src/test/java/com/predic8/membrane/core/transport/http/HttpTimeoutTest.java

---

📝 Walkthrough

Walkthrough

The test HttpTimeoutTest.httpTimeout was updated to assert the correct HTTP status code for timeout scenarios. When a backend request exceeds the configured timeout, the gateway now correctly responds with 504 Gateway Timeout instead of 500 Internal Server Error, and the test assertion reflects this change.

Changes

Timeout Status Code Assertion

Layer / File(s)	Summary
Timeout status code assertion update core/src/test/java/com/predic8/membrane/core/transport/http/HttpTimeoutTest.java	The httpTimeout test assertion now expects status code 504 instead of 500 when the backend exceeds the configured timeout.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A timeout once worn the wrong mask so gray,
Five-hundred it claimed when the gateway went astray,
But five-oh-four's truth—a gateway's delay!
Now the test hops in sync, both correct, hip-hooray!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the primary change: updating the test to expect a different HTTP status code (504 instead of 500).
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix-http-timeout-test

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[christiangoerdes]

/ok-to-test