-
Notifications
You must be signed in to change notification settings - Fork 167
Add support for YAML hot deployment and configuration reloading #2959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
christiangoerdes
wants to merge
14
commits into
master
Choose a base branch
from
yaml-hot-deployment
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5cdec9b
Add support for YAML hot deployment and configuration reloading
christiangoerdes 6bac0a4
Log proxy info and startup details after YAML reload
christiangoerdes bcd5b95
Ensure thread-safety for YAML configuration methods in DefaultRouter
christiangoerdes a538e0d
Add robust error handling and recovery for YAML configuration reloads
christiangoerdes 3b99867
Ensure thread-safety for resetForYamlReload method in DefaultRouter
christiangoerdes 9a4b4e1
Ensure thread-safety for enabled flag in DefaultHotDeployer
christiangoerdes acf176a
Merge branch 'master' into yaml-hot-deployment
christiangoerdes d66b21f
Refactor YAML configuration reloading by introducing ConfigurationRel…
christiangoerdes c61ec0a
Add tests for YAML hot deployment with error handling and recovery
christiangoerdes 0ab75db
Simplify logging messages for YAML configuration reload and change de…
christiangoerdes e46a45a
Refactor error logging for YAML configuration reload failures
christiangoerdes dca061e
Add documentation comments for YAML hot deployment and reloading comp…
christiangoerdes 31cfdad
Add Javadoc comment for YamlConfigurationSource
christiangoerdes 4e00b3d
Merge branch 'master' into yaml-hot-deployment
christiangoerdes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
core/src/main/java/com/predic8/membrane/core/router/YamlConfigurationSource.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /* Copyright 2026 predic8 GmbH, www.predic8.com | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. */ | ||
|
|
||
| package com.predic8.membrane.core.router; | ||
|
|
||
| import java.nio.file.Path; | ||
| import java.util.List; | ||
|
|
||
| /** Root YAML location and included local YAML files. */ | ||
| public record YamlConfigurationSource(String location, List<Path> trackedFiles) { | ||
|
|
||
| public YamlConfigurationSource { | ||
| trackedFiles = trackedFiles == null ? List.of() : List.copyOf(trackedFiles); | ||
| } | ||
| } |
97 changes: 97 additions & 0 deletions
97
core/src/main/java/com/predic8/membrane/core/router/YamlRouterBootstrap.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,97 @@ | ||
| /* Copyright 2026 predic8 GmbH, www.predic8.com | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. */ | ||
|
|
||
| package com.predic8.membrane.core.router; | ||
|
|
||
| import com.predic8.membrane.annot.beanregistry.BeanDefinition; | ||
| import com.predic8.membrane.annot.beanregistry.BeanDefinitions; | ||
| import com.predic8.membrane.annot.beanregistry.BeanRegistryImplementation; | ||
| import com.predic8.membrane.core.config.spring.GrammarAutoGenerated; | ||
|
|
||
| import java.net.URI; | ||
| import java.net.URISyntaxException; | ||
| import java.nio.file.InvalidPathException; | ||
| import java.nio.file.Path; | ||
| import java.util.LinkedHashSet; | ||
| import java.util.List; | ||
|
|
||
| import static com.predic8.membrane.core.util.OSUtil.isWindowsAbsolutePath; | ||
| import static com.predic8.membrane.core.util.URIUtil.pathFromFileURI; | ||
|
|
||
| /** | ||
| * Parses YAML into a router instance and returns the local files that can later be watched for hot reloads. | ||
| */ | ||
| public final class YamlRouterBootstrap { | ||
|
|
||
| private YamlRouterBootstrap() { | ||
| } | ||
|
|
||
| public static YamlConfigurationSource loadIntoRouter(DefaultRouter router, String location) throws Exception { | ||
| var grammar = new GrammarAutoGenerated(); | ||
| var registry = new BeanRegistryImplementation(grammar); | ||
|
|
||
| router.setRegistry(registry); | ||
| registry.register("router", router); | ||
|
|
||
| List<BeanDefinition> definitions = registry.parseYamlBeanDefinitions( | ||
| router.getResolverMap().resolve(location), | ||
| grammar, | ||
| getRootSourceFile(location) | ||
| ); | ||
|
|
||
| BeanDefinitions beanDefinitions = new BeanDefinitions(definitions); | ||
| beanDefinitions.ensureSingleGlobalDefinition(); | ||
| beanDefinitions.getConfigDefinition().ifPresent(configBd -> router.applyConfiguration((Configuration) registry.resolve(configBd.getName()))); | ||
|
|
||
| registry.finishStaticConfiguration(); | ||
| router.getConfiguration().setBaseLocation(location); | ||
| return new YamlConfigurationSource(location, collectTrackedFiles(location, definitions)); | ||
| } | ||
|
|
||
| static List<Path> collectTrackedFiles(String location, List<BeanDefinition> definitions) { | ||
| LinkedHashSet<Path> trackedFiles = new LinkedHashSet<>(); | ||
|
|
||
| Path rootSourceFile = getRootSourceFile(location); | ||
| if (rootSourceFile != null) { | ||
| trackedFiles.add(rootSourceFile.toAbsolutePath().normalize()); | ||
| } | ||
|
|
||
| for (BeanDefinition definition : definitions) { | ||
| if (definition.getSourceMetadata() == null || definition.getSourceMetadata().sourceFile() == null) { | ||
| continue; | ||
| } | ||
| trackedFiles.add(definition.getSourceMetadata().sourceFile().toAbsolutePath().normalize()); | ||
| } | ||
|
|
||
| return List.copyOf(trackedFiles); | ||
| } | ||
|
|
||
| static Path getRootSourceFile(String location) { | ||
| if (!isWindowsAbsolutePath(location)) { | ||
| try { | ||
| URI uri = new URI(location); | ||
| String scheme = uri.getScheme(); | ||
| if (scheme != null && !"file".equalsIgnoreCase(scheme)) | ||
| return null; | ||
| } catch (URISyntaxException ignored) { | ||
| } | ||
| } | ||
|
|
||
| try { | ||
| return Path.of(pathFromFileURI(location)); | ||
| } catch (InvalidPathException ignored) { | ||
| return null; | ||
| } | ||
| } | ||
| } |
25 changes: 25 additions & 0 deletions
25
core/src/main/java/com/predic8/membrane/core/router/hotdeploy/ConfigurationReloader.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /* Copyright 2026 predic8 GmbH, www.predic8.com | ||
|
|
||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
|
|
||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
|
|
||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. */ | ||
|
|
||
| package com.predic8.membrane.core.router.hotdeploy; | ||
|
|
||
| import java.nio.file.Path; | ||
| import java.util.List; | ||
|
|
||
| public interface ConfigurationReloader { | ||
|
|
||
| boolean reload(); | ||
|
|
||
| List<Path> trackedFiles(); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.