Postpone handle child terminated#1125
Merged
Merged
Conversation
varsill
added
the
no-changelog
…/membraneframework/membrane_core into postpone_handle_child_terminated
mat-hek
approved these changes
May 12, 2026
Comment on lines
+268
to
+270
| update_in(state, [:children, data.supervisor_pid], fn supervisor_data -> | ||
| Map.put(supervisor_data, :pending_child_death, {data.name, reason}) | ||
| end) |
Member
There was a problem hiding this comment.
How about
Suggested change
| update_in(state, [:children, data.supervisor_pid], fn supervisor_data -> | |
| Map.put(supervisor_data, :pending_child_death, {data.name, reason}) | |
| end) | |
| put_in(state.children[data.supervisor_pid].pending_child_death, {data.name, reason}) |
Also, initialise the pending_child_death to nil in handle_call(:start_component, ...)
Comment on lines
+253
to
+259
| case data do | ||
| %{pending_child_death: {child_name, death_reason}} -> | ||
| Message.send(state.parent_component, :child_death, [child_name, death_reason]) | ||
|
|
||
| _no_pending_death -> | ||
| :ok | ||
| end |
Member
There was a problem hiding this comment.
Let's move the case out of the parent case. Both can also be refactored to withs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
handle_child_terminatedis only called when given components subprocess supervisor is already dead