Fix 1.20.0 warnings#1146
Merged
Merged
Conversation
kidq330
added
the
no-changelog
mat-hek
reviewed
Jun 10, 2026
| Message.send(state.parent_pid, :child_pad_removed, [state.name, pad_ref]) | ||
| PadModel.delete_data!(state, pad_ref) | ||
| else | ||
| state |
Member
There was a problem hiding this comment.
Suggested change
| state | |
| # This is to handle the case when a bin pad is removed and then the bin removes its child linked to this pad | |
| state |
| defmodule Vertex do | ||
| @moduledoc false | ||
| require Membrane.Pad, as: Pad | ||
| alias Membrane.Pad, as: Pad |
Member
There was a problem hiding this comment.
Applies to all alias A.B.C, as: C cases
Suggested change
| alias Membrane.Pad, as: Pad | |
| alias Membrane.Pad |
|
|
||
| setup do | ||
| if Telemetry.legacy?() do | ||
| if Telemetry.legacy?() |> identity() do |
Member
There was a problem hiding this comment.
Suggested change
| if Telemetry.legacy?() |> identity() do | |
| if Telemetry.legacy?() |> Function.identity() do |
Co-authored-by: Mateusz Front <mateusz.front@swmansion.com>
FelonEkonom
reviewed
Jun 22, 2026
mat-hek
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.