-
Notifications
You must be signed in to change notification settings - Fork 2
Add SNTP-synced system time #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
noahp
wants to merge
5
commits into
noahp/heartbeat-led
Choose a base branch
from
noahp/sntp
base: noahp/heartbeat-led
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # Enable DMA for heartbeat LED | ||
| CONFIG_DMA=y | ||
| CONFIG_LED_STRIP=y |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,7 @@ | ||
| # Enable external SPI RAM | ||
| CONFIG_SPI=y | ||
| CONFIG_ESP_SPIRAM=y | ||
|
|
||
| # Enable DMA for heartbeat LED | ||
| CONFIG_DMA=y | ||
| CONFIG_LED_STRIP=y |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # Enable DMA + LED_STRIP for heartbeat LED | ||
| CONFIG_DMA=y | ||
| CONFIG_LED_STRIP=y |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| CONFIG_HEARTBEAT_LED_GPIO=y |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,15 @@ | ||
| &wifi { | ||
| status = "okay"; | ||
| }; | ||
|
|
||
| /* Enable the ESP32 RTC timer counter so it can be used for time persistence | ||
| * across soft resets via the counter API and __noinit RAM anchor. */ | ||
| &rtc_timer { | ||
| status = "okay"; | ||
| }; | ||
|
|
||
| / { | ||
| aliases { | ||
| heartbeat-led = &red_led; | ||
| }; | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| // Define the WiFi scan result count max metric | ||
| // This tracks the maximum number of WiFi scan results seen during each heartbeat period | ||
| MEMFAULT_METRICS_KEY_DEFINE(wifi_scan_result_count_max, kMemfaultMetricType_Unsigned) | ||
|
|
||
| // Number of successful SNTP time synchronizations in this heartbeat period | ||
| MEMFAULT_METRICS_KEY_DEFINE(sntp_sync_count, kMemfaultMetricType_Unsigned) | ||
|
|
||
| // Clock error corrected by the most recent SNTP sync (seconds, signed). | ||
| // Only recorded when the system clock was already valid (> 2023) before the | ||
| // sync, so the initial 1970-epoch → real-time jump is excluded. | ||
| MEMFAULT_METRICS_KEY_DEFINE(sntp_sync_delta_seconds, kMemfaultMetricType_Signed) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| // Wi-Fi Watchdog is not desirable, but should not impact stability score. | ||
| MEMFAULT_EXPECTED_REBOOT_REASON_DEFINE(WifiWatchdog) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
sntp_sync_successful_countwould be a bit more specific here (granted, I might not think this if I wasn't biased withsync_success/sync_failuredevice vitals 😅)