Skip to content

Commit 8428755

Browse files
committed
temporary removal of edited at
1 parent 21fa96d commit 8428755

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

  • src/server/api/go/internal/modules/service

src/server/api/go/internal/modules/service/session.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,6 @@ func (s *sessionService) GetMessages(ctx context.Context, in GetMessagesInput) (
523523
if len(triggerChecks) > 0 {
524524
// Evaluate trigger on the same editable prefix used by pin_editing_strategies_at_message.
525525
triggerMessages := out.Items
526-
effectivePin := ""
527526
if in.PinEditingStrategiesAtMessage != "" {
528527
pinIndex := -1
529528
for i := range out.Items {
@@ -533,7 +532,6 @@ func (s *sessionService) GetMessages(ctx context.Context, in GetMessagesInput) (
533532
}
534533
}
535534
if pinIndex != -1 {
536-
effectivePin = in.PinEditingStrategiesAtMessage
537535
triggerMessages = out.Items[:pinIndex+1]
538536
}
539537
}
@@ -552,13 +550,15 @@ func (s *sessionService) GetMessages(ctx context.Context, in GetMessagesInput) (
552550
}
553551
}
554552

555-
if !applyEditStrategies && len(out.Items) > 0 {
556-
if effectivePin != "" {
557-
out.EditAtMessageID = effectivePin
558-
} else {
559-
out.EditAtMessageID = out.Items[len(out.Items)-1].ID.String()
560-
}
561-
}
553+
// TODO(maintainers): clarify final semantics for edit_at_message_id when trigger does not fire.
554+
// Should it remain empty (strict "strategies were applied" meaning), or keep a reusable pin hint?
555+
// if !applyEditStrategies && len(out.Items) > 0 {
556+
// if effectivePin != "" {
557+
// out.EditAtMessageID = effectivePin
558+
// } else {
559+
// out.EditAtMessageID = out.Items[len(out.Items)-1].ID.String()
560+
// }
561+
// }
562562
}
563563

564564
if applyEditStrategies {

0 commit comments

Comments
 (0)