Skip to content

Commit 559e051

Browse files
chore: address review comments
1 parent df1650a commit 559e051

3 files changed

Lines changed: 14 additions & 6 deletions

File tree

.github/workflows/release.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,14 @@ jobs:
2222

2323
steps:
2424
- name: Checkout
25-
uses: actions/checkout@v4
25+
uses: actions/checkout@93cb6efe18208431cddfb8368fd83d5badbf9bfd
2626
with:
2727
fetch-depth: 0
2828

2929
- name: Setup Node
30-
uses: actions/setup-node@v4
30+
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020
3131
with:
32-
node-version: 20
32+
node-version-file: '.nvmrc'
3333

3434
- name: Enable corepack
3535
run: corepack enable
@@ -58,15 +58,15 @@ jobs:
5858
echo "tgz=mendix-native-${{ steps.bump.outputs.version }}.tgz" >> $GITHUB_OUTPUT
5959
6060
- name: Create GitHub Release
61-
uses: softprops/action-gh-release@v2
61+
uses: softprops/action-gh-release@a06a81a03ee405af7f2048a818ed3f03bbf83c7b
6262
with:
6363
tag_name: ${{ steps.bump.outputs.version }}
6464
name: ${{ steps.bump.outputs.version }}
6565
body: ${{ steps.changelog.outputs.notes }}
6666
files: ${{ steps.pack.outputs.tgz }}
6767

6868
- name: Create Pull Request
69-
uses: peter-evans/create-pull-request@v6
69+
uses: peter-evans/create-pull-request@84ae59a2cdc2258d6fa0732dd66352dddae2a412
7070
with:
7171
commit-message: "chore: release ${{ steps.bump.outputs.version }}"
7272
branch: release/${{ steps.bump.outputs.version }}

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v18
1+
24

lefthook.yml

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,14 @@ pre-commit:
77
types:
88
glob: "*.{js,ts, jsx, tsx}"
99
run: npx tsc
10+
version-check:
11+
glob: "package.json"
12+
run: |
13+
if git diff --cached package.json | grep -q '^\+.*"version":'; then
14+
echo "❌ Error: Direct version bumps in package.json are not allowed."
15+
echo "Please use the release workflow to bump versions."
16+
exit 1
17+
fi
1018
commit-msg:
1119
parallel: true
1220
commands:

0 commit comments

Comments
 (0)