fix: handle file deletion on download failure and improve error handling

Author: YogendraShelke

android/src/main/java/com/mendix/mendixnative/react/download/DownloadHelper.kt

@@ -43,23 +43,31 @@ fun downloadFile(
   outputFile.parentFile?.mkdirs()
   outputFile.createNewFile()
 
-  client.newCall(Request.Builder().url(url).get().build()).enqueue(object : Callback {
-    override fun onFailure(call: Call, e: IOException) = onFailure(e)
-
-    override fun onResponse(call: Call, response: Response) {
-      try {
-        DownloadResponseHandler(
-          response,
-          expectedMimeType,
-          outputFile,
-          progressCallback,
-        ).handle()
-        onSuccess()
-      } catch (e: Exception) {
+  try {
+    client.newCall(Request.Builder().url(url).get().build()).enqueue(object : Callback {
+      override fun onFailure(call: Call, e: IOException) {
+        outputFile.delete()
         onFailure(e)
       }
-    }
-  })
+
+      override fun onResponse(call: Call, response: Response) {
+        try {
+          DownloadResponseHandler(
+            response,
+            expectedMimeType,
+            outputFile,
+            progressCallback,
+          ).handle()
+          onSuccess()
+        } catch (e: Exception) {
+          onFailure(e)
+        }
+      }
+    })
+  } catch (e: Exception) {
+    outputFile.delete()
+    throw e
+  }
 }
 
 

example/__tests__/download-handler.harness.ts

@@ -21,7 +21,7 @@ describe('NativeDownloadHandler', () => {
     };
 
     await expect(
-      await NativeDownloadHandler.download(
+      NativeDownloadHandler.download(
         '://definitely-invalid-url',
         downloadPath,
         config
@@ -39,11 +39,7 @@ describe('NativeDownloadHandler', () => {
     const originalConfig = { ...config };
 
     await expect(
-      await NativeDownloadHandler.download(
-        '://still-invalid',
-        downloadPath,
-        config
-      )
+      NativeDownloadHandler.download('://still-invalid', downloadPath, config)
     ).rejects.toBeDefined();
 
     expect(config).toEqual(originalConfig);