Skip to content

Commit f2ddaa0

Browse files
committed
fix: reverted the chunking mechanism and tests
1 parent 366cdf0 commit f2ddaa0

7 files changed

Lines changed: 7 additions & 418 deletions

File tree

android/src/main/java/com/mendixnative/cookie/MxCookieModule.kt

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.mendixnative.cookie
22

3-
import com.facebook.react.bridge.Arguments
43
import com.facebook.react.bridge.Promise
54
import com.facebook.react.bridge.ReactApplicationContext
65
import com.facebook.react.module.annotations.ReactModule
@@ -19,21 +18,6 @@ class MxCookieModule(reactContext: ReactApplicationContext) :
1918
cookieModule.clearAll(promise)
2019
}
2120

22-
// The following methods are iOS-only (keychain / SessionCookieStore).
23-
// They are no-ops on Android so the TurboModule spec is satisfied.
24-
25-
override fun persistTestCookies(count: Double, valueSize: Double, promise: Promise) {
26-
promise.resolve(null)
27-
}
28-
29-
override fun restoreSessionCookies(promise: Promise) {
30-
promise.resolve(Arguments.createArray())
31-
}
32-
33-
override fun getKeychainChunkCount(promise: Promise) {
34-
promise.resolve(0.0)
35-
}
36-
3721
companion object {
3822
const val NAME = "MxCookie"
3923
}

example/__tests__/session-cookie-store.harness.ts

Lines changed: 0 additions & 192 deletions
This file was deleted.

ios/Modules/NativeCookieModule/NativeCookieModule.swift

Lines changed: 0 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -18,41 +18,4 @@ public class NativeCookieModule: NSObject {
1818
// MARK: - Test / diagnostic helpers (DEBUG builds only)
1919
// These methods are excluded from release builds to prevent cookie injection,
2020
// session DoS, and keychain information disclosure from arbitrary JS callers.
21-
22-
#if DEBUG
23-
/// Writes `count` synthetic session cookies with `valueSize`-byte values directly
24-
/// to the keychain (bypasses HTTPCookieStorage) and resolves once the write completes.
25-
public func persistTestCookies(count: Int, valueSize: Int, promise: Promise) {
26-
SessionCookieStore.persistTestCookies(count: count, valueSize: valueSize) {
27-
promise.resolve(nil)
28-
}
29-
}
30-
31-
public func restoreSessionCookies(_ promise: Promise) {
32-
let names = SessionCookieStore.restoreTestCookieNames()
33-
promise.resolve(names)
34-
}
35-
36-
/// Returns the integer stored in the `_chunkcount` commit-marker keychain item,
37-
/// or `0` if no chunked write exists (single-item or empty).
38-
public func getKeychainChunkCount(_ promise: Promise) {
39-
let bundleId = Bundle.main.bundleIdentifier ?? "com.mendix.app"
40-
let countKey = bundleId + "sessionCookies_chunkcount"
41-
let query: [CFString: Any] = [
42-
kSecClass: kSecClassGenericPassword,
43-
kSecAttrAccount: countKey,
44-
kSecReturnData: true,
45-
]
46-
var ref: CFTypeRef?
47-
let status = SecItemCopyMatching(query as CFDictionary, &ref)
48-
if status == errSecSuccess,
49-
let data = ref as? Data,
50-
let str = String(data: data, encoding: .utf8),
51-
let count = Int(str) {
52-
promise.resolve(NSNumber(value: count))
53-
} else {
54-
promise.resolve(NSNumber(value: 0))
55-
}
56-
}
57-
#endif
5821
}

0 commit comments

Comments
 (0)