Skip to content

Commit 6a03ba0

Browse files
Merge pull request #1072 from mendix/patch-deprecated-kotlin-function
fix: Deprecated Kotlin extension function used in react native screens package
2 parents 02e077a + 780aad6 commit 6a03ba0

3 files changed

Lines changed: 17 additions & 2 deletions

File tree

.github/workflows/ios-build-custom-dev-app.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,9 @@ jobs:
1313

1414
steps:
1515
- uses: actions/checkout@v3
16-
- name: switch XCode to 15.4
16+
- name: switch XCode to 16.4
1717
run: |
18-
sudo xcode-select -s /Applications/Xcode_15.4.app
18+
sudo xcode-select -s /Applications/Xcode_16.4.app
1919
2020
- name: update bundle identifier in Dev config
2121
shell: bash

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66

77
## [Unreleased]
88

9+
- We have fixed deprecated kotin extension function used in react native screens package.
10+
911
## [11.0.4] - 2025-01-15
1012

1113
- We resolved an issue with the bundle identifier in the Dev scheme on Xcode.

patches/react-native-screens+3.29.0.patch

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,16 @@
1+
diff --git a/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenStack.kt b/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenStack.kt
2+
index 46d86c8..2088006 100644
3+
--- a/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenStack.kt
4+
+++ b/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenStack.kt
5+
@@ -312,7 +312,7 @@ class ScreenStack(context: Context?) : ScreenContainer(context) {
6+
}
7+
8+
private fun obtainDrawingOp(): DrawingOp =
9+
- if (drawingOpPool.isEmpty()) DrawingOp() else drawingOpPool.removeLast()
10+
+ if (drawingOpPool.isEmpty()) DrawingOp() else drawingOpPool.removeAt(drawingOpPool.lastIndex)
11+
12+
private inner class DrawingOp {
13+
var canvas: Canvas? = null
114
diff --git a/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenViewManager.kt b/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenViewManager.kt
215
index 5f77aa1..0a67b1f 100644
316
--- a/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenViewManager.kt

0 commit comments

Comments
 (0)