Skip to content

Commit ddb39b8

Browse files
Merge pull request #1232 from mendix/moo/MOO-2325-add-patched-library
[MOO-2325] Fix for patched native lib and gradle repo order
2 parents 51f3650 + 1b72574 commit ddb39b8

6 files changed

Lines changed: 108 additions & 12 deletions

File tree

android/app/build.gradle

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ apply plugin: 'org.jetbrains.kotlin.plugin.compose'
5555
* Set this to true to Run Proguard on Release builds to minify the Java bytecode.
5656
*/
5757
def enableProguardInReleaseBuilds = false
58+
def firebaseBomVersion = rootProject.ext['react-native']['versions']['firebase']['bom']
5859

5960
android {
6061
ndkVersion rootProject.ndkVersion
@@ -112,6 +113,7 @@ android {
112113

113114
dependencies {
114115
implementation "com.facebook.react:react-android"
116+
implementation platform("com.google.firebase:firebase-bom:${firebaseBomVersion}")
115117

116118
implementation "androidx.core:core-ktx:1.3.2"
117119
implementation "org.jetbrains.kotlin:kotlin-stdlib:$kotlinVersion"

android/build.gradle

Lines changed: 43 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -58,24 +58,24 @@ project.ext {
5858

5959
allprojects {
6060
repositories {
61-
all { repo ->
62-
println repo.url.toString()
63-
if (repo.url.toString().contains("jcenter.bintray.com") || repo.url.toString().contains("jitpack.io")) {
64-
project.logger.warn "Repository ${repo.url} removed."
65-
remove repo
66-
google()
67-
mavenCentral()
68-
}
69-
}
61+
google()
62+
mavenCentral()
63+
64+
// Notifee local libs - ONLY for app.notifee
7065
maven {
7166
url "$rootDir/../node_modules/@notifee/react-native/android/libs"
67+
content {
68+
includeGroup "app.notifee"
69+
}
7270
}
73-
google()
71+
7472
maven {
7573
url "https://maven.fabric.io/public"
7674
}
77-
maven { url "https://www.jitpack.io" }
78-
maven { url "https://packages.rnd.mendix.com/jcenter" }
75+
76+
maven {
77+
url "https://packages.rnd.mendix.com/jcenter"
78+
}
7979

8080
// Build all modules with Android 16KB pages enabled
8181
plugins.withId('com.android.application') {
@@ -104,4 +104,35 @@ allprojects {
104104
}
105105
}
106106

107+
// Clean up phase: remove auto-added repositories and re-add JitPack correctly
108+
afterEvaluate { project ->
109+
def jitpackRemoved = false
110+
111+
project.repositories.removeAll { repo ->
112+
def repoUrl = repo.url.toString()
113+
114+
// Remove deprecated JCenter
115+
if (repoUrl.contains("jcenter.bintray.com")) {
116+
return true
117+
}
118+
119+
// Remove auto-added JitPack (re-added below)
120+
if (repoUrl.contains("jitpack.io")) {
121+
jitpackRemoved = true
122+
return true
123+
}
124+
125+
return false
126+
}
127+
128+
if (jitpackRemoved) {
129+
project.repositories {
130+
maven {
131+
url "https://www.jitpack.io"
132+
}
133+
}
134+
}
135+
136+
}
137+
107138
apply plugin: "com.facebook.react.rootproject"

ios/Podfile.lock

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2174,6 +2174,9 @@ PODS:
21742174
- ReactCommon/turbomodule/core
21752175
- SocketRocket
21762176
- Yoga
2177+
- react-native-track-player (4.1.2):
2178+
- React-Core
2179+
- SwiftAudioEx (= 1.1.0)
21772180
- react-native-vector-icons (12.3.0):
21782181
- boost
21792182
- DoubleConversion
@@ -3394,6 +3397,7 @@ PODS:
33943397
- SDWebImage/Core (~> 5.17)
33953398
- SocketRocket (0.7.1)
33963399
- SSZipArchive (2.6.0)
3400+
- SwiftAudioEx (1.1.0)
33973401
- Yoga (0.0.0)
33983402

33993403
DEPENDENCIES:
@@ -3449,6 +3453,7 @@ DEPENDENCIES:
34493453
- react-native-image-picker (from `../node_modules/react-native-image-picker`)
34503454
- react-native-pager-view (from `../node_modules/react-native-pager-view`)
34513455
- react-native-safe-area-context (from `../node_modules/react-native-safe-area-context`)
3456+
- react-native-track-player (from `../node_modules/react-native-track-player`)
34523457
- "react-native-vector-icons (from `../node_modules/@react-native-vector-icons/get-image`)"
34533458
- "react-native-vector-icons-material-icons (from `../node_modules/@react-native-vector-icons/material-icons`)"
34543459
- react-native-video (from `../node_modules/react-native-video`)
@@ -3516,6 +3521,7 @@ SPEC REPOS:
35163521
- SDWebImageWebPCoder
35173522
- SocketRocket
35183523
- SSZipArchive
3524+
- SwiftAudioEx
35193525

35203526
EXTERNAL SOURCES:
35213527
boost:
@@ -3619,6 +3625,8 @@ EXTERNAL SOURCES:
36193625
:path: "../node_modules/react-native-pager-view"
36203626
react-native-safe-area-context:
36213627
:path: "../node_modules/react-native-safe-area-context"
3628+
react-native-track-player:
3629+
:path: "../node_modules/react-native-track-player"
36223630
react-native-vector-icons:
36233631
:path: "../node_modules/@react-native-vector-icons/get-image"
36243632
react-native-vector-icons-material-icons:
@@ -3778,6 +3786,7 @@ SPEC CHECKSUMS:
37783786
react-native-image-picker: b16541b587b275e81a12f9b82f215c5e9b0ccbf3
37793787
react-native-pager-view: a0516effb17ca5120ac2113bfd21b91130ad5748
37803788
react-native-safe-area-context: befb5404eb8a16fdc07fa2bebab3568ecabcbb8a
3789+
react-native-track-player: dd56f9948e03756a217c75e0a61aa04aab65b5a1
37813790
react-native-vector-icons: 6ba2060e1b82ce0663f14375579fe1d48e9b668a
37823791
react-native-vector-icons-material-icons: 2fe75632937d07937bfe8ca953e1b5d06eef3a1d
37833792
react-native-video: f8e9788554c53a1852166cd119d6e7c324b16dfe
@@ -3834,6 +3843,7 @@ SPEC CHECKSUMS:
38343843
SDWebImageWebPCoder: 0e06e365080397465cc73a7a9b472d8a3bd0f377
38353844
SocketRocket: d4aabe649be1e368d1318fdf28a022d714d65748
38363845
SSZipArchive: 8a6ee5677c8e304bebc109e39cf0da91ccef22ea
3846+
SwiftAudioEx: f6aa653770f3a0d3851edaf8d834a30aee4a7646
38373847
Yoga: 447c8baf495b8d96457a46e6691a2c9952cbd07f
38383848

38393849
PODFILE CHECKSUM: 007913bf46b5b3d85747fd4f0aea854dd063fbc2

package-lock.json

Lines changed: 24 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
"@react-native-vector-icons/get-image": "12.3.0",
4343
"@react-native-vector-icons/material-icons": "12.4.1",
4444
"react-native-video": "6.19.2",
45+
"react-native-track-player": "4.1.2",
4546
"semver": "7.7.4"
4647
},
4748
"devDependencies": {
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
diff --git a/node_modules/react-native-track-player/android/src/main/java/com/doublesymmetry/trackplayer/module/MusicModule.kt b/node_modules/react-native-track-player/android/src/main/java/com/doublesymmetry/trackplayer/module/MusicModule.kt
2+
index b2409a09939164c49c0f7a16bb6d3284e8eab8fb..699a6e4f4e2652eca69cd1d3a522c21971fee1b4 100644
3+
--- a/node_modules/react-native-track-player/android/src/main/java/com/doublesymmetry/trackplayer/module/MusicModule.kt
4+
+++ b/node_modules/react-native-track-player/android/src/main/java/com/doublesymmetry/trackplayer/module/MusicModule.kt
5+
@@ -545,7 +545,7 @@ class MusicModule(reactContext: ReactApplicationContext) : ReactContextBaseJavaM
6+
if (verifyServiceBoundOrReject(callback)) return@launch
7+
8+
if (index >= 0 && index < musicService.tracks.size) {
9+
- callback.resolve(Arguments.fromBundle(musicService.tracks[index].originalItem))
10+
+ callback.resolve(musicService.tracks[index].originalItem?.let { Arguments.fromBundle(it) })
11+
} else {
12+
callback.resolve(null)
13+
}
14+
@@ -584,9 +584,11 @@ class MusicModule(reactContext: ReactApplicationContext) : ReactContextBaseJavaM
15+
if (verifyServiceBoundOrReject(callback)) return@launch
16+
callback.resolve(
17+
if (musicService.tracks.isEmpty()) null
18+
- else Arguments.fromBundle(
19+
- musicService.tracks[musicService.getCurrentTrackIndex()].originalItem
20+
- )
21+
+ else musicService.tracks[musicService.getCurrentTrackIndex()].originalItem?.let {
22+
+ Arguments.fromBundle(
23+
+ it
24+
+ )
25+
+ }
26+
)
27+
}
28+

0 commit comments

Comments
 (0)