Skip to content

fix: Deprecated Kotlin extension function used in react native screens package #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YogendraShelke merged 2 commits into from
Aug 25, 2025
Merged

fix: Deprecated Kotlin extension function used in react native screens package #1072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e579460
fix: Deprecated kotlin extension function used in react native screen…
YogendraShelke Aug 25, 2025
780aad6
Upgrade to Xcode 16.4 for iOS build
YogendraShelke Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ios-build-custom-dev-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ jobs:

steps:
- uses: actions/checkout@v3
- name: switch XCode to 15.4
- name: switch XCode to 16.4
run: |
sudo xcode-select -s /Applications/Xcode_15.4.app
sudo xcode-select -s /Applications/Xcode_16.4.app

- name: update bundle identifier in Dev config
shell: bash
Expand Down
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

- We have fixed deprecated kotin extension function used in react native screens package.

## [11.0.4] - 2025-01-15

- We resolved an issue with the bundle identifier in the Dev scheme on Xcode.
Expand Down
13 changes: 13 additions & 0 deletions patches/react-native-screens+3.29.0.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,16 @@
diff --git a/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenStack.kt b/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenStack.kt
index 46d86c8..2088006 100644
--- a/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenStack.kt
+++ b/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenStack.kt
@@ -312,7 +312,7 @@ class ScreenStack(context: Context?) : ScreenContainer(context) {
}

private fun obtainDrawingOp(): DrawingOp =
- if (drawingOpPool.isEmpty()) DrawingOp() else drawingOpPool.removeLast()
+ if (drawingOpPool.isEmpty()) DrawingOp() else drawingOpPool.removeAt(drawingOpPool.lastIndex)

private inner class DrawingOp {
var canvas: Canvas? = null
diff --git a/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenViewManager.kt b/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenViewManager.kt
index 5f77aa1..0a67b1f 100644
--- a/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenViewManager.kt
Expand Down
Loading