Skip to content

Commit 0052ff7

Browse files
committed
chore: use recommended userEvent instead of fireEvent; update dependencies
1 parent 37d5b08 commit 0052ff7

4 files changed

Lines changed: 23 additions & 20 deletions

File tree

packages/pluggableWidgets/feedback-native/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,14 @@
2020
},
2121
"dependencies": {
2222
"@mendix/piw-native-utils-internal": "*",
23-
"querystringify": "^2.1.1",
24-
"react-native-dialog": "9.2.2",
23+
"querystringify": "^2.2.0",
24+
"react-native-dialog": "9.3.0",
2525
"react-native-view-shot": "4.0.3"
2626
},
2727
"devDependencies": {
2828
"@mendix/piw-utils-internal": "1.0.0",
2929
"@mendix/pluggable-widgets-tools": "*",
30-
"@types/querystringify": "^2.0.0",
31-
"@types/react-native-dialog": "^5.5.0"
30+
"@types/querystringify": "^2.0.2",
31+
"@types/react-native-dialog": "^5.6.3"
3232
}
3333
}

packages/pluggableWidgets/feedback-native/src/Feedback.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,10 +63,10 @@ export class Feedback extends Component<FeedbackProps<FeedbackStyle>, State> {
6363
supportedOrientations: ["portrait", "landscape"]
6464
};
6565

66-
componentDidMount() {
66+
UNSAFE_componentDidMount() {
6767
Dimensions.addEventListener("change", this.updateDeviceHeight);
6868
}
69-
componentDidUpdate(_: Readonly<FeedbackProps<FeedbackStyle>>, prevState: Readonly<State>) {
69+
UNSAFE_componentDidUpdate(_: Readonly<FeedbackProps<FeedbackStyle>>, prevState: Readonly<State>) {
7070
if (
7171
["todo", "inprogress"].includes(prevState.status) &&
7272
this.state.status === "closingDialog" &&

packages/pluggableWidgets/feedback-native/src/__tests__/Feedback.spec.tsx

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { FeedbackStyle } from "../ui/styles";
2-
import { fireEvent, render, waitFor, cleanup } from "@testing-library/react-native";
2+
import { render, cleanup, userEvent } from "@testing-library/react-native";
33
import { createElement } from "react";
44
import { FeedbackProps } from "../../typings/FeedbackProps";
55
import { Feedback } from "../Feedback";
@@ -52,12 +52,15 @@ describe("Feedback", () => {
5252

5353
it("should call the api when sending", async () => {
5454
const feedbackMsg = "unittest";
55+
const user = userEvent.setup();
5556
const component = render(<Feedback {...defaultProps} />);
56-
fireEvent.press(component.getByTestId("feedback-test$button"));
57-
await waitFor(() => {
58-
fireEvent.changeText(component.getByTestId("feedback-test$input"), feedbackMsg);
59-
});
60-
fireEvent.press(component.getByTestId("feedback-test$send"));
57+
58+
await user.press(component.getByTestId("feedback-test$button"));
59+
60+
await user.type(component.getByTestId("feedback-test$input"), feedbackMsg);
61+
62+
await user.press(component.getByTestId("feedback-test$send"));
63+
6164
expect(fetch).toHaveBeenCalledWith(
6265
"https://feedback-api.mendix.com/rest/v3/feedbackapi/projects/sprintr-app-id/issues",
6366
{

pnpm-lock.yaml

Lines changed: 8 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)