Skip to content

Commit 141e26b

Browse files
committed
Update tests and runtime retries
1 parent 02530d1 commit 141e26b

5 files changed

Lines changed: 30 additions & 12 deletions

File tree

packages/pluggableWidgets/bottom-sheet-native/e2e/specs/maestro/Bottom_sheet_expanding.yaml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,10 @@ appId: "${APP_ID}"
88
text: "Bottom Sheet"
99
- tapOn:
1010
text: "Expanding"
11-
- assertVisible:
12-
text: "Header"
11+
# Because the image loading can take some time due to resources on emulator, we need to wait for the image to be visible
12+
- extendedWaitUntil:
13+
visible: randText # Any random text that does not exist in the UI
14+
optional: true # This should be true so that the test won't fail
15+
timeout: 10000 # 10 seconds
16+
- takeScreenshot:
17+
path: "maestro/images/actual/${PLATFORM}/bottom_sheet_expanding"

packages/pluggableWidgets/bottom-sheet-native/e2e/specs/maestro/Botton_sheet_expanding_fullscreen.yaml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,10 @@ appId: "${APP_ID}"
88
text: "Bottom Sheet"
99
- tapOn:
1010
text: "Expanding fullscreen"
11-
- assertVisible:
12-
text: "Header"
11+
# Because the image loading can take some time due to resources on emulator, we need to wait for the image to be visible
12+
- extendedWaitUntil:
13+
visible: randText # Any random text that does not exist in the UI
14+
optional: true # This should be true so that the test won't fail
15+
timeout: 10000 # 10 seconds
16+
- takeScreenshot:
17+
path: "maestro/images/actual/${PLATFORM}/bottom_sheet_expanding_fullscreen"

packages/pluggableWidgets/bottom-sheet-native/e2e/specs/maestro/Modal_basic_non_native.yaml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,10 @@ appId: "${APP_ID}"
1010
text: "Modal basic non native"
1111
- tapOn:
1212
text: "Open"
13-
- tapOn:
14-
text: "Diego"
13+
# Because the image loading can take some time due to resources on emulator, we need to wait for the image to be visible
14+
- extendedWaitUntil:
15+
visible: randText # Any random text that does not exist in the UI
16+
optional: true # This should be true so that the test won't fail
17+
timeout: 10000 # 10 seconds
18+
- takeScreenshot:
19+
path: "maestro/images/actual/${PLATFORM}/bottom_sheet_modal_basic_non_native"

packages/pluggableWidgets/bottom-sheet-native/e2e/specs/maestro/Modal_custom.yaml

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,10 @@ appId: "${APP_ID}"
1010
text: "Modal custom"
1111
- tapOn:
1212
text: "Open"
13-
- tapOn:
14-
text: "test"
15-
- assertVisible:
16-
text: "Successfully opened"
13+
# Because the image loading can take some time due to resources on emulator, we need to wait for the image to be visible
14+
- extendedWaitUntil:
15+
visible: randText # Any random text that does not exist in the UI
16+
optional: true # This should be true so that the test won't fail
17+
timeout: 5000 # 5 seconds
18+
- takeScreenshot:
19+
path: "maestro/images/actual/${PLATFORM}/bottom_sheet_modal_custom"

packages/pluggableWidgets/safe-area-view-native/e2e/specs/maestro/SafeAreaViewMaps.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,6 @@ appId: "${APP_ID}"
1414
- tapOn:
1515
text: "OK"
1616
optional: true
17-
- takeScreenshot:
18-
path: "maestro/images/actual/${PLATFORM}/SafeAreaViewMaps"
17+
# - takeScreenshot:
18+
# path: "maestro/images/actual/${PLATFORM}/SafeAreaViewMaps"
1919

0 commit comments

Comments
 (0)