Skip to content

Commit d1976d9

Browse files
fix(MOO-803): react-native-video version update to 6.4.5 (MIN-10.13) (#179)
2 parents 3506a33 + eb44c34 commit d1976d9

7 files changed

Lines changed: 22 additions & 61 deletions

File tree

packages/jsActions/mobile-resources-native/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,4 +53,4 @@
5353
"rimraf": "^2.7.1",
5454
"rollup": "^2.68.0"
5555
}
56-
}
56+
}

packages/pluggableWidgets/video-player-native/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66

77
## [Unreleased]
88

9+
### Changed
10+
11+
- We have updated `react-native-video` version to 6.4.5
12+
913
## [5.0.1] - 2024-8-29
1014

1115
### Fixed

packages/pluggableWidgets/video-player-native/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "video-player-native",
33
"widgetName": "VideoPlayer",
4-
"version": "5.0.1",
4+
"version": "6.0.0",
55
"license": "Apache-2.0",
66
"repository": {
77
"type": "git",
@@ -23,7 +23,7 @@
2323
"deprecated-react-native-prop-types": "^4.0.0",
2424
"react-native-system-navigation-bar": "2.6.3",
2525
"react-native-vector-icons": "10.0.3",
26-
"react-native-video": "5.2.1"
26+
"react-native-video": "6.4.5"
2727
},
2828
"devDependencies": {
2929
"@mendix/piw-utils-internal": "1.0.0",

packages/pluggableWidgets/video-player-native/src/VideoPlayer.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import {
1212
NativeModules,
1313
Pressable
1414
} from "react-native";
15-
import Video, { OnProgressData, VideoProperties } from "react-native-video";
15+
import Video, { OnProgressData, ReactVideoProps, VideoRef } from "react-native-video";
1616
import Icon from "react-native-vector-icons/MaterialIcons";
1717
import { VideoPlayerProps } from "../typings/VideoPlayerProps";
1818
import { defaultVideoStyle, VideoStyle } from "./ui/Styles";
@@ -29,8 +29,8 @@ const enum StatusEnum {
2929
export function VideoPlayer(props: VideoPlayerProps<VideoStyle>): ReactElement {
3030
const [styles, setStyles] = useState(flattenStyles(defaultVideoStyle, props.style));
3131
const timeoutRef = useRef<NodeJS.Timeout>();
32-
const playerRef = useRef<Video>(null);
33-
const fullScreenPlayerRef = useRef<Video>(null);
32+
const playerRef = useRef<VideoRef>(null);
33+
const fullScreenPlayerRef = useRef<VideoRef>(null);
3434
const [status, setStatus] = useState(StatusEnum.NOT_READY);
3535
const [videoAspectRatio, setVideoAspectRatio] = useState(0);
3636
const [fullScreen, setFullScreen] = useState(false);
@@ -100,7 +100,7 @@ export function VideoPlayer(props: VideoPlayerProps<VideoStyle>): ReactElement {
100100
}
101101
}
102102

103-
const videoProps: VideoProperties = {
103+
const videoProps: ReactVideoProps = {
104104
testID: props.name,
105105
source: { uri: isAvailable(props.videoUrl) ? props.videoUrl.value : undefined },
106106
muted: props.muted,

packages/pluggableWidgets/video-player-native/src/__tests__/VideoPlayer.spec.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { dynamicValue } from "@mendix/piw-utils-internal";
22
import { createElement } from "react";
33
import { Modal, View } from "react-native";
44
import { fireEvent, render, waitFor } from "@testing-library/react-native";
5-
import { VideoProperties } from "react-native-video";
5+
import { ReactVideoProps } from "react-native-video";
66

77
import { VideoPlayer } from "../VideoPlayer";
88
import { VideoPlayerProps } from "../../typings/VideoPlayerProps";
@@ -38,7 +38,7 @@ describe("VideoPlayer", () => {
3838

3939
it("passes the right props to the video player", () => {
4040
const component = render(<VideoPlayer {...defaultProps} />);
41-
const props = component.getByTestId("video-player-test").props as VideoProperties;
41+
const props = component.getByTestId("video-player-test").props as ReactVideoProps;
4242

4343
expect(props.source).toEqual({ uri: "https://mendix.com/video.mp4" });
4444
expect(props.paused).toBe(true);

packages/pluggableWidgets/video-player-native/src/package.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
<?xml version="1.0" encoding="utf-8" ?>
22
<package xmlns="http://www.mendix.com/package/1.0/">
3-
<clientModule name="VideoPlayer" version="5.0.1" xmlns="http://www.mendix.com/clientModule/1.0/">
3+
<clientModule name="VideoPlayer" version="6.0.0" xmlns="http://www.mendix.com/clientModule/1.0/">
44
<widgetFiles>
55
<widgetFile path="VideoPlayer.xml" />
66
</widgetFiles>

yarn.lock

Lines changed: 8 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -3916,13 +3916,6 @@ __metadata:
39163916
languageName: node
39173917
linkType: hard
39183918

3919-
"@react-native/normalize-color@npm:*":
3920-
version: 2.1.0
3921-
resolution: "@react-native/normalize-color@npm:2.1.0"
3922-
checksum: 10/a72b98538e6b7e265fb0669b8767d5f788777fb1a0ac1df7b0c82d8b3a804c8122aa7b819688c5e36fcf90b5ba93050b0070e29d3f0d70ab9530c2abd2bb9f9e
3923-
languageName: node
3924-
linkType: hard
3925-
39263919
"@react-native/normalize-color@npm:^2.0.0":
39273920
version: 2.0.0
39283921
resolution: "@react-native/normalize-color@npm:2.0.0"
@@ -7633,17 +7626,6 @@ __metadata:
76337626
languageName: node
76347627
linkType: hard
76357628

7636-
"deprecated-react-native-prop-types@npm:^2.2.0":
7637-
version: 2.3.0
7638-
resolution: "deprecated-react-native-prop-types@npm:2.3.0"
7639-
dependencies:
7640-
"@react-native/normalize-color": "npm:*"
7641-
invariant: "npm:*"
7642-
prop-types: "npm:*"
7643-
checksum: 10/5abbad5b6d6830ca92151167f42611256ada1e8991b5066ed3659f3bbe909ae87949f3e7f075f1b685256138cad81423222220f4c6d5740376db19cb9f793312
7644-
languageName: node
7645-
linkType: hard
7646-
76477629
"deprecated-react-native-prop-types@npm:^4.0.0":
76487630
version: 4.0.0
76497631
resolution: "deprecated-react-native-prop-types@npm:4.0.0"
@@ -7925,13 +7907,6 @@ __metadata:
79257907
languageName: node
79267908
linkType: hard
79277909

7928-
"eme-encryption-scheme-polyfill@npm:^2.0.1":
7929-
version: 2.1.1
7930-
resolution: "eme-encryption-scheme-polyfill@npm:2.1.1"
7931-
checksum: 10/312fab39d5f2d59fcca97148c9f85c50081591b465f6f43b6ab30dc0cab27609ce32a59b67849a8b9316bdcc25b3ff7ebb1f923ae470d10c3136ba95e5496371
7932-
languageName: node
7933-
linkType: hard
7934-
79357910
"emittery@npm:^0.13.1":
79367911
version: 0.13.1
79377912
resolution: "emittery@npm:0.13.1"
@@ -11754,13 +11729,6 @@ __metadata:
1175411729
languageName: node
1175511730
linkType: hard
1175611731

11757-
"keymirror@npm:^0.1.1":
11758-
version: 0.1.1
11759-
resolution: "keymirror@npm:0.1.1"
11760-
checksum: 10/be8f0bc5ff7d561d729f935ef55b4dbbea7b56a4714f044a2212088730f4d52f73935c38c5a9604e0f1157611725ee493cb7d08d1f3eb34151c0aa999236206a
11761-
languageName: node
11762-
linkType: hard
11763-
1176411732
"kind-of@npm:^5.0.0":
1176511733
version: 5.1.0
1176611734
resolution: "kind-of@npm:5.1.0"
@@ -15573,15 +15541,13 @@ __metadata:
1557315541
languageName: node
1557415542
linkType: hard
1557515543

15576-
"react-native-video@npm:5.2.1":
15577-
version: 5.2.1
15578-
resolution: "react-native-video@npm:5.2.1"
15579-
dependencies:
15580-
deprecated-react-native-prop-types: "npm:^2.2.0"
15581-
keymirror: "npm:^0.1.1"
15582-
prop-types: "npm:^15.7.2"
15583-
shaka-player: "npm:^2.5.9"
15584-
checksum: 10/bd44c45bbcfa13209bf317ec7e5bf63aa73778ab38a7868d74ea1e4b9b7d781fd155cbc8612d5cd1579f89ae324e3c7956de47a20645c026cf91784b9db7d714
15544+
"react-native-video@npm:6.4.5":
15545+
version: 6.4.5
15546+
resolution: "react-native-video@npm:6.4.5"
15547+
peerDependencies:
15548+
react: "*"
15549+
react-native: "*"
15550+
checksum: 10/dfaf802c5dbde81d022528e325babd443bd0d08e77eef3cc959c7c2a9087632dd4b7b35efa2ba92dab202f2f3aeb52aa97334d2499b532d13cfd78d6599a787e
1558515551
languageName: node
1558615552
linkType: hard
1558715553

@@ -16668,15 +16634,6 @@ __metadata:
1666816634
languageName: node
1666916635
linkType: hard
1667016636

16671-
"shaka-player@npm:^2.5.9":
16672-
version: 2.5.23
16673-
resolution: "shaka-player@npm:2.5.23"
16674-
dependencies:
16675-
eme-encryption-scheme-polyfill: "npm:^2.0.1"
16676-
checksum: 10/985ec3baaeb239d68e8af6a631eed53cb7a3d7b2eb877c95954cf645ef9d946421c94fc52fc4a305ce7fce1931426f26c401278a27e87a9479d82ddb729d1fa8
16677-
languageName: node
16678-
linkType: hard
16679-
1668016637
"shallow-clone@npm:^1.0.0":
1668116638
version: 1.0.0
1668216639
resolution: "shallow-clone@npm:1.0.0"
@@ -18623,7 +18580,7 @@ __metadata:
1862318580
eslint: "npm:^7.20.0"
1862418581
react-native-system-navigation-bar: "npm:2.6.3"
1862518582
react-native-vector-icons: "npm:10.0.3"
18626-
react-native-video: "npm:5.2.1"
18583+
react-native-video: "npm:6.4.5"
1862718584
languageName: unknown
1862818585
linkType: soft
1862918586

0 commit comments

Comments
 (0)