Skip to content

Commit 06ca11f

Browse files
test(accessibility-helper): remove spurious double-click and disabled-state assertion
actionButton2 stays data-disabled after its action runs by design — asserting it re-enables was semantically wrong and caused permanent failures. All six multiple-targets tests now use single-click + waitForMendixApp, matching the proven pattern from the three passing tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 13c48e7 commit 06ca11f

1 file changed

Lines changed: 0 additions & 15 deletions

File tree

packages/pluggableWidgets/accessibility-helper-web/e2e/AccessibilityHelper.spec.js

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,6 @@ test.describe("with single target", () => {
5757
});
5858
test.describe("with multiple targets", () => {
5959
test("sets attributes when condition is true", async ({ page }) => {
60-
await page.click(".mx-name-actionButton2");
61-
await waitForMendixApp(page);
62-
await expect(page.locator(".mx-name-actionButton2")).not.toHaveAttribute("data-disabled", "true", {
63-
timeout: 10000
64-
});
6560
await page.click(".mx-name-actionButton2");
6661
await waitForMendixApp(page);
6762
await page.click(".mx-name-radioButtons2 input:first-child");
@@ -92,11 +87,6 @@ test.describe("with single target", () => {
9287
});
9388

9489
test("updates target attributes using a NF", async ({ page }) => {
95-
await page.click(".mx-name-actionButton2");
96-
await waitForMendixApp(page);
97-
await expect(page.locator(".mx-name-actionButton2")).not.toHaveAttribute("data-disabled", "true", {
98-
timeout: 10000
99-
});
10090
await page.click(".mx-name-actionButton2");
10191
await waitForMendixApp(page);
10292
await page.click(".mx-name-radioButtons2 input:first-child");
@@ -125,11 +115,6 @@ test.describe("with single target", () => {
125115
test("sets target attributes even though target is conditionally shown after being hidden", async ({
126116
page
127117
}) => {
128-
await page.click(".mx-name-actionButton2");
129-
await waitForMendixApp(page);
130-
await expect(page.locator(".mx-name-actionButton2")).not.toHaveAttribute("data-disabled", "true", {
131-
timeout: 10000
132-
});
133118
await page.click(".mx-name-actionButton2");
134119
await waitForMendixApp(page);
135120
await page.click(".mx-name-radioButtons2 input:first-child");

0 commit comments

Comments
 (0)