Skip to content

Commit a14d634

Browse files
committed
fix: remove unused isopen
1 parent 1a191df commit a14d634

3 files changed

Lines changed: 2 additions & 5 deletions

File tree

packages/pluggableWidgets/combobox-web/src/components/MultiSelection/MultiSelection.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,14 +93,13 @@ export function MultiSelection({
9393
const ariaLabels = useMemo(
9494
() =>
9595
getComboboxAriaLabels({
96-
isOpen,
9796
hasSelection: selectedItems.length > 0,
9897
selectedValue: selectedItems.map(id => selector.caption.get(id)).join(", "),
9998
inputLabel,
10099
labelledBy: inputProps["aria-labelledby"],
101100
fallbackAriaLabel: options.ariaLabel
102101
}),
103-
[isOpen, selectedItems, inputLabel, inputProps, options.ariaLabel, selector.caption]
102+
[selectedItems, inputLabel, inputProps, options.ariaLabel, selector.caption]
104103
);
105104

106105
return (

packages/pluggableWidgets/combobox-web/src/components/SingleSelection/SingleSelection.tsx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,14 +85,13 @@ export function SingleSelection({
8585
const ariaLabels = useMemo(
8686
() =>
8787
getComboboxAriaLabels({
88-
isOpen,
8988
hasSelection: Boolean(selectedItem),
9089
selectedValue: selectedItem ? selector.caption.get(selectedItem) : "",
9190
inputLabel,
9291
labelledBy: inputProps["aria-labelledby"],
9392
fallbackAriaLabel: options.ariaLabel
9493
}),
95-
[isOpen, selectedItem, inputLabel, inputProps, options.ariaLabel, selector.caption]
94+
[selectedItem, inputLabel, inputProps, options.ariaLabel, selector.caption]
9695
);
9796

9897
return (

packages/pluggableWidgets/combobox-web/src/helpers/utils.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,6 @@ export function getValidationErrorId(inputId?: string): string | undefined {
173173
* aria-label to be announced, we must NOT set aria-labelledby at all.
174174
*/
175175
export function getComboboxAriaLabels(params: {
176-
isOpen: boolean;
177176
hasSelection: boolean;
178177
selectedValue: string;
179178
inputLabel: Element | null;

0 commit comments

Comments
 (0)